You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/07/20 08:19:40 UTC

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1220: HDDS-3986. Frequent failure in TestCommitWatcher#testReleaseBuffersOnException

adoroszlai opened a new pull request #1220:
URL: https://github.com/apache/hadoop-ozone/pull/1220


   ## What changes were proposed in this pull request?
   
   1. Fix frequent failure in `TestCommitWatcher`, caused by the following.
   
   Watch request times out with `TimeoutIOException`:
   
   https://github.com/apache/incubator-ratis/blob/6ab75ae9da4b380056279b02f208dc9b1329325b/ratis-grpc/src/main/java/org/apache/ratis/grpc/client/GrpcClientProtocolClient.java#L336-L339
   
   which results in no retry per the policy:
   
   https://github.com/apache/hadoop-ozone/blob/caf471111cdb9168ec013f4526bb997aa513e079/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/ratis/RatisHelper.java#L291-L309
   
   The original exception is then propagated to client instead of `RaftRetryFailureException`:
   
   https://github.com/apache/incubator-ratis/blob/6ab75ae9/ratis-client/src/main/java/org/apache/ratis/client/impl/RaftClientImpl.java#L324-L330
   
   Thus the assertion for exception type fails.
   
   2. Also reduce request timeout to reduce the time required for the test.
   
   https://issues.apache.org/jira/browse/HDDS-3986
   
   ## How was this patch tested?
   
   Ran TestCommitWatcher 20 times:
   https://github.com/adoroszlai/hadoop-ozone/runs/888869761#step:5:4


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1220: HDDS-3986. Frequent failure in TestCommitWatcher#testReleaseBuffersOnException

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1220:
URL: https://github.com/apache/hadoop-ozone/pull/1220#issuecomment-661912899


   Thanks @lokeshj1703 for reviewing and committing it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] lokeshj1703 commented on pull request #1220: HDDS-3986. Frequent failure in TestCommitWatcher#testReleaseBuffersOnException

Posted by GitBox <gi...@apache.org>.
lokeshj1703 commented on pull request #1220:
URL: https://github.com/apache/hadoop-ozone/pull/1220#issuecomment-661910181


   @adoroszlai Thanks for the contribution! I have committed the PR to master branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] lokeshj1703 closed pull request #1220: HDDS-3986. Frequent failure in TestCommitWatcher#testReleaseBuffersOnException

Posted by GitBox <gi...@apache.org>.
lokeshj1703 closed pull request #1220:
URL: https://github.com/apache/hadoop-ozone/pull/1220


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org