You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/20 18:18:49 UTC
[GitHub] [incubator-superset] mistercrunch opened a new pull request #10970: style: fix checkbox color
mistercrunch opened a new pull request #10970:
URL: https://github.com/apache/incubator-superset/pull/10970
<img width="594" alt="Screen Shot 2020-09-20 at 9 52 03 AM" src="https://user-images.githubusercontent.com/487433/93718761-02f90700-fb33-11ea-9bd1-8905172209da.png">
<img width="590" alt="Screen Shot 2020-09-20 at 11 17 42 AM" src="https://user-images.githubusercontent.com/487433/93718764-042a3400-fb33-11ea-873c-dc8757bf3ab5.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #10970: style: fix checkbox color
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10970:
URL: https://github.com/apache/incubator-superset/pull/10970#issuecomment-696195874
Yes @JunlinC it's related, it's just fixing the color
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on pull request #10970: style: fix checkbox color
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #10970:
URL: https://github.com/apache/incubator-superset/pull/10970#issuecomment-698534497
this PR breaks the filter_box control:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10970: style: fix checkbox color
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10970:
URL: https://github.com/apache/incubator-superset/pull/10970#issuecomment-696319814
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10970?src=pr&el=h1) Report
> Merging [#10970](https://codecov.io/gh/apache/incubator-superset/pull/10970?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3d8f757ac8c963936dad2d0527055a2347f799b8?el=desc) will **decrease** coverage by `4.48%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10970?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10970 +/- ##
==========================================
- Coverage 65.85% 61.37% -4.49%
==========================================
Files 815 815
Lines 38324 38336 +12
Branches 3600 3599 -1
==========================================
- Hits 25238 23528 -1710
- Misses 12984 14622 +1638
- Partials 102 186 +84
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `61.76% <100.00%> (+0.01%)` | :arrow_up: |
| #python | `61.14% <ø> (-0.31%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10970?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/CheckboxIcons.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3hJY29ucy50c3g=) | `85.71% <ø> (ø)` | |
| [...uperset-frontend/src/components/Checkbox/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvaW5kZXgudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [182 more](https://codecov.io/gh/apache/incubator-superset/pull/10970/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10970?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10970?src=pr&el=footer). Last update [3d8f757...c87a610](https://codecov.io/gh/apache/incubator-superset/pull/10970?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] JunlinC commented on pull request #10970: style: fix checkbox color
Posted by GitBox <gi...@apache.org>.
JunlinC commented on pull request #10970:
URL: https://github.com/apache/incubator-superset/pull/10970#issuecomment-695882963
Max, is this PR related to https://github.com/apache/incubator-superset/pull/10799 ? Replaces the use of font-awesome for checkboxes with the svg components that already exist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] JunlinC commented on pull request #10970: style: fix checkbox color
Posted by GitBox <gi...@apache.org>.
JunlinC commented on pull request #10970:
URL: https://github.com/apache/incubator-superset/pull/10970#issuecomment-695882963
Max, is this PR related to https://github.com/apache/incubator-superset/pull/10799 ? Replaces the use of font-awesome for checkboxes with the svg components that already exist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on pull request #10970: style: fix checkbox color
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #10970:
URL: https://github.com/apache/incubator-superset/pull/10970#issuecomment-698534497
this PR breaks the filter_box control:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #10970: style: fix checkbox color
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10970:
URL: https://github.com/apache/incubator-superset/pull/10970#issuecomment-696195874
Yes @JunlinC it's related, it's just fixing the color
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #10970: style: fix checkbox color
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #10970:
URL: https://github.com/apache/incubator-superset/pull/10970
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #10970: style: fix checkbox color
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #10970:
URL: https://github.com/apache/incubator-superset/pull/10970
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10970: style: fix checkbox color
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10970:
URL: https://github.com/apache/incubator-superset/pull/10970#issuecomment-696319814
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10970?src=pr&el=h1) Report
> Merging [#10970](https://codecov.io/gh/apache/incubator-superset/pull/10970?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3d8f757ac8c963936dad2d0527055a2347f799b8?el=desc) will **decrease** coverage by `4.48%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10970?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10970 +/- ##
==========================================
- Coverage 65.85% 61.37% -4.49%
==========================================
Files 815 815
Lines 38324 38336 +12
Branches 3600 3599 -1
==========================================
- Hits 25238 23528 -1710
- Misses 12984 14622 +1638
- Partials 102 186 +84
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `61.76% <100.00%> (+0.01%)` | :arrow_up: |
| #python | `61.14% <ø> (-0.31%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10970?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/CheckboxIcons.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3hJY29ucy50c3g=) | `85.71% <ø> (ø)` | |
| [...uperset-frontend/src/components/Checkbox/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvaW5kZXgudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10970/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [182 more](https://codecov.io/gh/apache/incubator-superset/pull/10970/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10970?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10970?src=pr&el=footer). Last update [3d8f757...c87a610](https://codecov.io/gh/apache/incubator-superset/pull/10970?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org