You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2019/10/08 03:17:56 UTC
[GitHub] [ignite] skarpushin commented on a change in pull request #6947:
IGNITE-12261 - Issue with adding nested index dynamically
skarpushin commented on a change in pull request #6947: IGNITE-12261 - Issue with adding nested index dynamically
URL: https://github.com/apache/ignite/pull/6947#discussion_r332321638
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/query/QueryUtils.java
##########
@@ -835,7 +835,7 @@ public static QueryBinaryProperty buildBinaryProperty(GridKernalContext ctx, Str
fullName.append(prop);
- String alias = aliases.get(fullName.toString());
+ String alias = aliases.get(fullName.toString()) == null ? fullName.toString() : aliases.get(fullName.toString());
Review comment:
Why do `aliases.get(fullName.toString());` twice?
Suggestion:
```
String alias = aliases.get(fullName.toString());
if (alias == null) {
alias = fullName.toString();
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services