You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/24 05:16:20 UTC

[GitHub] [shardingsphere] sandynz opened a new pull request, #20479: Basic support migration to different database type

sandynz opened a new pull request, #20479:
URL: https://github.com/apache/shardingsphere/pull/20479

   Local test migration from Oracle to PostgreSQL.
   
   Include stages:
   - Data source check on preparation
   - Inventory dump and import
   - Data consistency check (Column type: varchar2, timestamp, number. More column types will be added later)
   
   Un-included stages:
   - Create schema and table
   - Incremental dump and import
   
   Changes proposed in this pull request:
   - Compatible with data source checker; case-sensitive table name metadata loading
   - And Oracle SQL builder impl; Improve Oracle query by page with ROWNUM
   - Compatible with inventory dumper and importer
   - Extract ColumnValueReader for common usage to resolve different database column java type mismatch
   - Compatible with data consistency check
   - Compatible with MySQL integration test
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yx9o merged pull request #20479: Basic support migration to different database type

Posted by GitBox <gi...@apache.org>.

yx9o merged PR #20479:
URL: https://github.com/apache/shardingsphere/pull/20479


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on pull request #20479: Basic support migration to different database type

Posted by GitBox <gi...@apache.org>.

sandynz commented on PR #20479:
URL: https://github.com/apache/shardingsphere/pull/20479#issuecomment-1225229396

   On column value match, some special cases notes:
   
   1, For timestamp column type, Oracle JDBC driver getObject and getTimestamp return different type of java object.
   
   resultSet.getObject(i).getClass().getName() return oracle.sql.TIMESTAMP.
   resultSet.getTimestamp(i).getClass().getName() return java.sql.Timestamp.
   
   2, java.math.BigDecimal value doesn't match if their scale doesn't match, even if values are equals.
   
   e.g. value1=332.2, value2=332.20, value1.class=java.math.BigDecimal, value2.class=java.math.BigDecimal
   They're not equals by BigDecimal.equals
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on pull request #20479: Basic support migration to different database type

Posted by GitBox <gi...@apache.org>.

sandynz commented on PR #20479:
URL: https://github.com/apache/shardingsphere/pull/20479#issuecomment-1225234639

   Quote on SQL builder is disabled for now, it need to do some improvement to support case-sensitive and case-insensitive databases in the same migration job.
   Table name and column name should be quoted only if they're sepcial keywords in this database.
   
   e.g. For column name case-insensitive database, real column name is `id`, `id` and `ID` in SQL are equivalent, but if it's quoted (e.g. `"ID"`) then column name is not matched.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org