You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/03 19:12:21 UTC

Review Request 66407: Updated CSI client to support v0.2.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66407/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Jie Yu.


Bugs: MESOS-8653
    https://issues.apache.org/jira/browse/MESOS-8653


Repository: mesos


Description
-------

To adapt the change in CSI package names (from `csi` to `csi.v0`), we
introduce a new `csi::v0` namespace in Mesos for v0 helpers. The CSI
client class is now defined in this namespace, and its public methods
are updated to reflect the changes in CSI v0.2.


Diffs
-----

  include/csi/spec.hpp da0caaedab76a203a12db8518a15444958b11975 
  src/csi/client.hpp 1d55994423df3e539205d5353677b8258fd30abf 
  src/csi/client.cpp 5df788f9b2f2331428375097660f8e4bd371e70d 
  src/tests/csi_client_tests.cpp 566a85eba5632d182bb100f793e73321523c94b4 
  src/tests/mock_csi_plugin.hpp b19870dc46709517a581c0fa4f1ab3cdec27ac82 
  src/tests/mock_csi_plugin.cpp 1dc87617b4ab904d9c50aaa3b3a07dd101a4a952 


Diff: https://reviews.apache.org/r/66407/diff/1/


Testing
-------

This patch cannot be compiled standalone.


Thanks,

Chun-Hung Hsiao

Re: Review Request 66407: Updated CSI client to support v0.2.

Posted by Jie Yu <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66407/#review201013
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On April 3, 2018, 7:12 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66407/
> -----------------------------------------------------------
> 
> (Updated April 3, 2018, 7:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8653
>     https://issues.apache.org/jira/browse/MESOS-8653
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To adapt the change in CSI package names (from `csi` to `csi.v0`), we
> introduce a new `csi::v0` namespace in Mesos for v0 helpers. The CSI
> client class is now defined in this namespace, and its public methods
> are updated to reflect the changes in CSI v0.2.
> 
> 
> Diffs
> -----
> 
>   include/csi/spec.hpp da0caaedab76a203a12db8518a15444958b11975 
>   src/csi/client.hpp 1d55994423df3e539205d5353677b8258fd30abf 
>   src/csi/client.cpp 5df788f9b2f2331428375097660f8e4bd371e70d 
>   src/tests/csi_client_tests.cpp 566a85eba5632d182bb100f793e73321523c94b4 
>   src/tests/mock_csi_plugin.hpp b19870dc46709517a581c0fa4f1ab3cdec27ac82 
>   src/tests/mock_csi_plugin.cpp 1dc87617b4ab904d9c50aaa3b3a07dd101a4a952 
> 
> 
> Diff: https://reviews.apache.org/r/66407/diff/1/
> 
> 
> Testing
> -------
> 
> This patch cannot be compiled standalone. Tests done later in the chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>