You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/02/18 09:33:42 UTC
[GitHub] [james-project] chibenwa opened a new pull request #303: JAMES-3499 Use a module chooser for LDAP users repository
chibenwa opened a new pull request #303:
URL: https://github.com/apache/james-project/pull/303
* Enables easy reuse for JPA & memory servers to provide
optional LDAP support out of the box.
* Drops Cassanra-ldap and Distributed-ldap servers. The
regular version should be used instead. Docker images
are maintained as is for now, but we can consider dropping
them as well (separated PR). Maven projects are kept for now
but only hosts tests.
* Ships the minimal LDAP dependency for everybody.
Reduction of server counts ease introducing new servers, for exemple
to let a grace period of one release to upgrade from ElasticSearch
version 6 to 7 (classpath clashes forces distinct maven projects;
the chooser trick can not be employed).
This is a drop-in, invisible replacement for people running ldap
docker images, as well for the CIs building these images.
If consensual:
- [ ] We likely can get rid of the 2 testing LDAP projects...
- [ ] We can discuss getting rid of the extra containers (will require changes to the soon to be deprecated linagora/james-jenkins CI)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa closed pull request #303: JAMES-3499 Use a module chooser for LDAP users repository
Posted by GitBox <gi...@apache.org>.
chibenwa closed pull request #303:
URL: https://github.com/apache/james-project/pull/303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa closed pull request #303: JAMES-3499 Use a module chooser for LDAP users repository
Posted by GitBox <gi...@apache.org>.
chibenwa closed pull request #303:
URL: https://github.com/apache/james-project/pull/303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on a change in pull request #303: JAMES-3499 Use a module chooser for LDAP users repository
Posted by GitBox <gi...@apache.org>.
Arsnael commented on a change in pull request #303:
URL: https://github.com/apache/james-project/pull/303#discussion_r578979482
##########
File path: dockerfiles/compilation/java-11/compile.sh
##########
@@ -73,16 +73,16 @@ unzip $GLOW_ROOT_ZIP
if [ $? -eq 0 ]; then
if [ -d "$CASSANDRA_RABBITMQ_LDAP_DESTINATION" ]; then
echo "Copying cassandra - rabbitMQ - Ldap JARs"
- cp server/container/guice/cassandra-rabbitmq-ldap-guice/target/james-server-cassandra-rabbitmq-ldap-guice.jar $CASSANDRA_RABBITMQ_LDAP_DESTINATION || true
- cp -r server/container/guice/cassandra-rabbitmq-ldap-guice/target/james-server-cassandra-rabbitmq-ldap-guice.lib $CASSANDRA_RABBITMQ_LDAP_DESTINATION || true
+ cp server/container/guice/cassandra-rabbitmq-guice/target/james-server-cassandra-rabbitmq-guice.jar $CASSANDRA_RABBITMQ_LDAP_DESTINATION || true
+ cp -r server/container/guice/cassandra-rabbitmq-guice/target/james-server-cassandra-rabbitmq-guice.lib $CASSANDRA_RABBITMQ_LDAP_DESTINATION || true
Review comment:
I don't think you want to change that. Seeing that you are basing your module chooser on whether or not you have an ldap conf in usersrepository.xml, if you point the build towards the conf of `cassandra-rabbitmq-guice`, you will not end up with a ldap support server here. You will likely generate twice the same cassandra-rabbitmq-guice image here, right?
##########
File path: dockerfiles/compilation/java-11/compile.sh
##########
@@ -98,8 +98,8 @@ if [ $? -eq 0 ]; then
cp server/container/cli/target/james-server-cli.jar $CASSANDRA_DESTINATION || true
cp -r server/container/cli/target/james-server-cli.lib $CASSANDRA_DESTINATION || true
- cp server/container/guice/cassandra-ldap-guice/target/james-server-cassandra-ldap-guice.jar $CASSANDRA_DESTINATION || true
- cp -r server/container/guice/cassandra-ldap-guice/target/james-server-cassandra-ldap-guice.lib $CASSANDRA_DESTINATION || true
+ cp server/container/guice/cassandra-guice/target/james-server-cassandra-guice.jar $CASSANDRA_DESTINATION || true
+ cp -r server/container/guice/cassandra-guice/target/james-server-cassandra-guice.lib $CASSANDRA_DESTINATION || true
Review comment:
idem as above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #303: JAMES-3499 Use a module chooser for LDAP users repository
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #303:
URL: https://github.com/apache/james-project/pull/303#issuecomment-783945072
This is :green_apple: on the CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #303: JAMES-3499 Use a module chooser for LDAP users repository
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #303:
URL: https://github.com/apache/james-project/pull/303#issuecomment-788577330
Merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on a change in pull request #303: JAMES-3499 Use a module chooser for LDAP users repository
Posted by GitBox <gi...@apache.org>.
Arsnael commented on a change in pull request #303:
URL: https://github.com/apache/james-project/pull/303#discussion_r578983519
##########
File path: dockerfiles/compilation/java-11/compile.sh
##########
@@ -73,16 +73,16 @@ unzip $GLOW_ROOT_ZIP
if [ $? -eq 0 ]; then
if [ -d "$CASSANDRA_RABBITMQ_LDAP_DESTINATION" ]; then
echo "Copying cassandra - rabbitMQ - Ldap JARs"
- cp server/container/guice/cassandra-rabbitmq-ldap-guice/target/james-server-cassandra-rabbitmq-ldap-guice.jar $CASSANDRA_RABBITMQ_LDAP_DESTINATION || true
- cp -r server/container/guice/cassandra-rabbitmq-ldap-guice/target/james-server-cassandra-rabbitmq-ldap-guice.lib $CASSANDRA_RABBITMQ_LDAP_DESTINATION || true
+ cp server/container/guice/cassandra-rabbitmq-guice/target/james-server-cassandra-rabbitmq-guice.jar $CASSANDRA_RABBITMQ_LDAP_DESTINATION || true
+ cp -r server/container/guice/cassandra-rabbitmq-guice/target/james-server-cassandra-rabbitmq-guice.lib $CASSANDRA_RABBITMQ_LDAP_DESTINATION || true
Review comment:
You are right I mixed things up here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #303: JAMES-3499 Use a module chooser for LDAP users repository
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #303:
URL: https://github.com/apache/james-project/pull/303#discussion_r578981192
##########
File path: dockerfiles/compilation/java-11/compile.sh
##########
@@ -73,16 +73,16 @@ unzip $GLOW_ROOT_ZIP
if [ $? -eq 0 ]; then
if [ -d "$CASSANDRA_RABBITMQ_LDAP_DESTINATION" ]; then
echo "Copying cassandra - rabbitMQ - Ldap JARs"
- cp server/container/guice/cassandra-rabbitmq-ldap-guice/target/james-server-cassandra-rabbitmq-ldap-guice.jar $CASSANDRA_RABBITMQ_LDAP_DESTINATION || true
- cp -r server/container/guice/cassandra-rabbitmq-ldap-guice/target/james-server-cassandra-rabbitmq-ldap-guice.lib $CASSANDRA_RABBITMQ_LDAP_DESTINATION || true
+ cp server/container/guice/cassandra-rabbitmq-guice/target/james-server-cassandra-rabbitmq-guice.jar $CASSANDRA_RABBITMQ_LDAP_DESTINATION || true
+ cp -r server/container/guice/cassandra-rabbitmq-guice/target/james-server-cassandra-rabbitmq-guice.lib $CASSANDRA_RABBITMQ_LDAP_DESTINATION || true
Review comment:
Here we only copy binaries, not the conf.
The conf comes from the dockerfiles folder. We should be good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org