You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/01/24 18:09:25 UTC

[GitHub] Antonio-Maranhao commented on issue #989: Basic validation of key values entered in the Query Options panel

Antonio-Maranhao commented on issue #989: Basic validation of key values entered in the Query Options panel
URL: https://github.com/apache/couchdb-fauxton/pull/989#issuecomment-360223035
 
 
   @popojargo sorry for the late reply. My thinking at the time was to have a quick fix. Having the field auto-quote was a bit trickier to implement (what if the string itself has quotes, and supporting single/double quotes, etc). So I settled for showing a warning instead. 
   
   I thought about adding the quotes behind the scenes, before sending the request, but the behavior would not be consistent. E.g. you don't use quotes for simple strings but still need them if you're using arrays. And even then if the user adds quotes themselves - do you just ignore, or are they part of the value?
   
   Maybe I am just overthinking though. :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services