[GitHub] [spark] boy-uber commented on a change in pull request #29916: [SPARK-33037] Add "spark.shuffle.manager" value to knownManagers to support user's custom shuffle manager plugin

[GitBox <gi...@apache.org>]

boy-uber commented on a change in pull request #29916:
URL: https://github.com/apache/spark/pull/29916#discussion_r497776968



##########
File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java
##########
@@ -135,6 +145,9 @@ public int weigh(File file, ShuffleIndexInformation indexInfo) {
       executors = Maps.newConcurrentMap();
     }
     this.directoryCleaner = directoryCleaner;
+    if (extraKnownManager != null) {
+      knownManagers.add(extraKnownManager);
+    }

Review comment:
       Yes, if user sets their own shuffle manager (spark.shuffle.manager), they need to be aware that their shuffle manager needs to work or co-exist with external shuffle service. Spark framework should let user make that decision instead of only allowing two hardcoded values ("org.apache.spark.shuffle.sort.SortShuffleManager", "org.apache.spark.shuffle.unsafe.UnsafeShuffleManager").
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org