[GitHub] spark pull request #16826: [SPARK-19540][SQL] Add ability to clone SparkSess...

[zsxwing <gi...@git.apache.org>]

Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16826#discussion_r103528893
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/ExperimentalMethods.scala ---
    @@ -46,4 +46,10 @@ class ExperimentalMethods private[sql]() {
     
       @volatile var extraOptimizations: Seq[Rule[LogicalPlan]] = Nil
     
    +  override def clone(): ExperimentalMethods = {
    --- End diff --
    
    @gatorsmile any reason you want to add `synchronized` here? `extraStrategies` and `extraOptimizations` are both `@volatile`. If you want to update them atomically, then we also need to add `synchronized` to other places that change `extraStrategies` and `extraOptimizations`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org