You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2019/12/11 11:56:59 UTC

[GitHub] [camel-kafka-connector] orpiske commented on issue #36: Adds support for ElasticSearch index operation + tests

orpiske commented on issue #36: Adds support for ElasticSearch index operation + tests
URL: https://github.com/apache/camel-kafka-connector/pull/36#issuecomment-564508072
 
 
   > However, I was thinking @orpiske do you think it makes sense to move that transformer to `test` folder since is only specific for ES IT tests?
   
   Thanks. So, I was hoping we could provide some simple way for the users to plug these 2 together as the standard transformations from Kafka seem to not work out of the box for some of these scenarios (ie.: Hoist converts either to a Struct or to a Map, which IMHO, can be subtle to debug/diagnose because it seems to choose one of the other depending on different factos). Therefore, I was hoping we could provide something that could be easier/simpler to kick off. 
   
   Another thing I was considering off is: since we don't have a ConnectRecord to Map converter on Camel ... would it make sense, instead, to rename the ElasticSearchTransformer to MapTransformer and approach it as generic transformer to map?
   
   What do you think? Does it make sense? 
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services