[GitHub] [iceberg] rdblue commented on a change in pull request #2945: Core: Add new writer interfaces

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #2945:
URL: https://github.com/apache/iceberg/pull/2945#discussion_r711290069



##########
File path: core/src/main/java/org/apache/iceberg/deletes/EqualityDeleteWriter.java
##########
@@ -56,10 +57,17 @@ public EqualityDeleteWriter(FileAppender<T> appender, FileFormat format, String
     this.equalityFieldIds = equalityFieldIds;
   }
 
+  @Override
+  public void write(T row) throws IOException {
+    appender.add(row);
+  }
+
+  @Deprecated

Review comment:
       It's a low-level API, but it could be used by external projects like Hive since this is the easiest way to correctly write Iceberg files. I think we should deprecate them like Anton did here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org