You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/11/11 15:43:23 UTC

[GitHub] [hudi] the-other-tim-brown commented on a diff in pull request #7180: [MINOR] add in minor perf wins in hudi-utilities and locking related tests

the-other-tim-brown commented on code in PR #7180:
URL: https://github.com/apache/hudi/pull/7180#discussion_r1020335149


##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/testutils/UtilitiesTestBase.java:
##########
@@ -155,6 +155,11 @@ public static void initTestServices(boolean needsHdfs, boolean needsHive, boolea
       zookeeperTestService = new ZookeeperTestService(hadoopConf);
       zookeeperTestService.start();
     }
+
+    jsc = UtilHelpers.buildSparkContext(UtilitiesTestBase.class.getName() + "-hoodie", "local[2]");

Review Comment:
   I think we should find a way to standardize on how to initialize spark for testing. There are a few patterns in the repo like bring up and teardown per test method vs per test class and which settings to add. Most are very similar so we can do that as a follow up.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org