[GitHub] [solr] dweiss commented on a change in pull request #615: SOLR-15992: Globally forbid and exclude known bad dependencies

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #615:
URL: https://github.com/apache/solr/pull/615#discussion_r802346111



##########
File path: gradle/hacks/global-exclude-dependencies.gradle
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// Globally exclude known bad dependencies to ensure they aren't included in any transitive dependency.
+
+allprojects { prj ->
+  plugins.withType(JavaPlugin) {
+    configurations.all {

Review comment:
       Don't exclude it from all configurations. Exclude these from only those configurations that are created by the java plugin. I've talked about it a few times - you have no control over what configurations are defined by plugins; if you exclude arbitrary dependencies from these, you risk hours spending debugging why something in the build doesn't work as expected.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org