[jira] [Commented] (PARQUET-481) Refactor and expand reader-test

["Wes McKinney (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123827#comment-15123827 ] 

Wes McKinney commented on PARQUET-481:
--------------------------------------

I feel very strongly about keeping the low-level unit tests next to the code they are testing and with (see for example the Kudu and Impala codebases) -- so {{foo.cc}} is accompanied by {{foo-test.cc}}. If we are doing some macro-level testing that spans the library let's create a separate directory and put those tests there. It's sort of disorganized right now -- {{reader-test.cc}} contains tests that belong in a {{column/reader-test.cc}} and {{column/scanner-test.cc}}. Let's create a common header file for unit tests containing test fixtures that can be shared amongst unit test suites

> Refactor and expand reader-test
> -------------------------------
>
>                 Key: PARQUET-481
>                 URL: https://issues.apache.org/jira/browse/PARQUET-481
>             Project: Parquet
>          Issue Type: Sub-task
>          Components: parquet-cpp
>    Affects Versions: cpp-0.1
>            Reporter: Aliaksei Sandryhaila
>            Assignee: Aliaksei Sandryhaila
>             Fix For: cpp-0.1
>
>
> reader-test currently tests with a single parquet file and only verifies that we can read it, not the correctness of the output.
> Proposed changes:
> - Move reader-test.cc to a separate directory parquet-cpp/tests (in the future, all unit tests will be located there)
> - Expand it to work with multiple files
> - Add method ParquetFileReader::JsonPrint() that prints a file contents in a json format, so we can consistently compare the output with the ground truth stored in parquet-cpp/data. This method will also be more handy than DebugPrint when we start working with nested columns.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)