You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/29 12:01:02 UTC
[GitHub] [shardingsphere] strongduanmu opened a new pull request, #23169: Fix encrypt shorthand expansion when execute subquery statement
strongduanmu opened a new pull request, #23169:
URL: https://github.com/apache/shardingsphere/pull/23169
Fixes #23163.
Changes proposed in this pull request:
- fix encrypt shorthand expansion when execute subquery statement
- add integration test case
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia merged pull request #23169: Fix encrypt shorthand expansion when execute subquery statement
Posted by GitBox <gi...@apache.org>.
taojintianxia merged PR #23169:
URL: https://github.com/apache/shardingsphere/pull/23169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23169: Fix encrypt shorthand expansion when execute subquery statement
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23169:
URL: https://github.com/apache/shardingsphere/pull/23169#issuecomment-1367287079
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23169?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23169](https://codecov.io/gh/apache/shardingsphere/pull/23169?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2a75e56) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a190fd5e3cc352545fbc7f0ec84015627b0ec132?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a190fd5) will **decrease** coverage by `0.00%`.
> The diff coverage is `26.08%`.
```diff
@@ Coverage Diff @@
## master #23169 +/- ##
============================================
- Coverage 49.97% 49.96% -0.01%
Complexity 2437 2437
============================================
Files 4116 4116
Lines 57630 57650 +20
Branches 9105 9107 +2
============================================
+ Hits 28801 28806 +5
- Misses 26297 26311 +14
- Partials 2532 2533 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...projection/impl/AggregationDistinctProjection.java](https://codecov.io/gh/apache/shardingsphere/pull/23169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc2VnbWVudC9zZWxlY3QvcHJvamVjdGlvbi9pbXBsL0FnZ3JlZ2F0aW9uRGlzdGluY3RQcm9qZWN0aW9uLmphdmE=) | `85.71% <0.00%> (-14.29%)` | :arrow_down: |
| [.../select/projection/impl/AggregationProjection.java](https://codecov.io/gh/apache/shardingsphere/pull/23169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc2VnbWVudC9zZWxlY3QvcHJvamVjdGlvbi9pbXBsL0FnZ3JlZ2F0aW9uUHJvamVjdGlvbi5qYXZh) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...gment/select/projection/impl/ColumnProjection.java](https://codecov.io/gh/apache/shardingsphere/pull/23169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc2VnbWVudC9zZWxlY3QvcHJvamVjdGlvbi9pbXBsL0NvbHVtblByb2plY3Rpb24uamF2YQ==) | `75.00% <0.00%> (ø)` | |
| [...ment/select/projection/impl/DerivedProjection.java](https://codecov.io/gh/apache/shardingsphere/pull/23169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc2VnbWVudC9zZWxlY3QvcHJvamVjdGlvbi9pbXBsL0Rlcml2ZWRQcm9qZWN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...t/select/projection/impl/ExpressionProjection.java](https://codecov.io/gh/apache/shardingsphere/pull/23169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc2VnbWVudC9zZWxlY3QvcHJvamVjdGlvbi9pbXBsL0V4cHJlc3Npb25Qcm9qZWN0aW9uLmphdmE=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...ect/projection/impl/ParameterMarkerProjection.java](https://codecov.io/gh/apache/shardingsphere/pull/23169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc2VnbWVudC9zZWxlY3QvcHJvamVjdGlvbi9pbXBsL1BhcmFtZXRlck1hcmtlclByb2plY3Rpb24uamF2YQ==) | `50.00% <0.00%> (ø)` | |
| [...nt/select/projection/impl/ShorthandProjection.java](https://codecov.io/gh/apache/shardingsphere/pull/23169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc2VnbWVudC9zZWxlY3QvcHJvamVjdGlvbi9pbXBsL1Nob3J0aGFuZFByb2plY3Rpb24uamF2YQ==) | `93.75% <0.00%> (-6.25%)` | :arrow_down: |
| [...ent/select/projection/impl/SubqueryProjection.java](https://codecov.io/gh/apache/shardingsphere/pull/23169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc2VnbWVudC9zZWxlY3QvcHJvamVjdGlvbi9pbXBsL1N1YnF1ZXJ5UHJvamVjdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ent/select/projection/engine/ProjectionEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/23169/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc2VnbWVudC9zZWxlY3QvcHJvamVjdGlvbi9lbmdpbmUvUHJvamVjdGlvbkVuZ2luZS5qYXZh) | `94.47% <50.00%> (-3.55%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org