You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "cadonna (via GitHub)" <gi...@apache.org> on 2023/12/06 15:45:18 UTC
[PR] MINOR: Fix flaky test testInvalidGroupId [kafka]
cadonna opened a new pull request, #14944:
URL: https://github.com/apache/kafka/pull/14944
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15991: Fix flaky test testGroupIdNotNullAndValid [kafka]
Posted by "cadonna (via GitHub)" <gi...@apache.org>.
cadonna closed pull request #14944: KAFKA-15991: Fix flaky test testGroupIdNotNullAndValid
URL: https://github.com/apache/kafka/pull/14944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15991: Fix flaky test testGroupIdNotNullAndValid [kafka]
Posted by "cadonna (via GitHub)" <gi...@apache.org>.
cadonna commented on PR #14944:
URL: https://github.com/apache/kafka/pull/14944#issuecomment-1864520722
Not needed anymore since https://github.com/apache/kafka/pull/14930 got merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15991: Fix flaky test testGroupIdNotNullAndValid [kafka]
Posted by "cadonna (via GitHub)" <gi...@apache.org>.
cadonna commented on PR #14944:
URL: https://github.com/apache/kafka/pull/14944#issuecomment-1850574652
@lucasbru This PR is ready to merge. Should I wait for https://github.com/apache/kafka/pull/14930 and close this since this is also solved that? Or should we just merge this as a temporary fix (at the cost of merge conflicts)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15991: Fix flaky test testGroupIdNotNullAndValid [kafka]
Posted by "lucasbru (via GitHub)" <gi...@apache.org>.
lucasbru commented on PR #14944:
URL: https://github.com/apache/kafka/pull/14944#issuecomment-1850757955
@cadonna If you have more comments on #14930, please feel free to merge this, I will anyways have conflicts with every single CTR/KIP-848 PR.
Instead, if #14930 is good to go, lets merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org