You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@paimon.apache.org by "JingsongLi (via GitHub)" <gi...@apache.org> on 2025/10/20 11:29:23 UTC

Re: [PR] [Python] clean code for pypaimon [paimon]

JingsongLi commented on code in PR #6433:
URL: https://github.com/apache/paimon/pull/6433#discussion_r2444746579


##########
paimon-python/pypaimon/common/predicate.py:
##########
@@ -50,93 +50,50 @@ def new_literals(self, literals: List[Any]):
             literals=literals)
 
     def test(self, record: InternalRow) -> bool:
+        if self.method == 'and':

Review Comment:
   Can we create a `dict[str, function]` for this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org