[GitHub] [commons-crypto] garydgregory commented on a diff in pull request #165: CRYPTO-162 openSslCipher support engine.

[GitBox <gi...@apache.org>]

garydgregory commented on code in PR #165:
URL: https://github.com/apache/commons-crypto/pull/165#discussion_r896652302


##########
src/main/java/org/apache/commons/crypto/cipher/OpenSsl.java:
##########
@@ -378,4 +378,7 @@ protected void finalize() throws Throwable {
         clean();
     }
 
+    public void engineSetDefaultCiphers(String engineId){

Review Comment:
   Missing Javadoc, fix formatting.



##########
src/main/java/org/apache/commons/crypto/cipher/OpenSslCipher.java:
##########
@@ -60,6 +60,11 @@ public OpenSslCipher(final Properties props, final String transformation) // NOP
         }
 
         openSslEngine = OpenSsl.getInstance(transformation);
+
+        String engineId = props.getProperty(CryptoCipherFactory.CIPHER_ENGINE_KEY);
+        if(engineId != null && !engineId.isEmpty()) {

Review Comment:
   Fix formatting. 



##########
src/main/java/org/apache/commons/crypto/cipher/OpenSslNative.java:
##########
@@ -159,4 +159,6 @@ public native static int doFinalByteArray(long context, byte[] output,
      * @param context The cipher context address
      */
     public native static void clean(long context);
+

Review Comment:
   Missing Javadoc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org