You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Nicolas Liochon (JIRA)" <ji...@apache.org> on 2013/09/17 17:12:55 UTC
[jira] [Commented] (HBASE-7462) TestDrainingServer is an
integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13769592#comment-13769592 ]
Nicolas Liochon commented on HBASE-7462:
----------------------------------------
The patch is ok. I've done some changes, all minor except one. See v3. I plan to commit it tomorrow.
The test now takes 2 seconds instead of 38 seconds to run. Nice. Thanks Gustavo.
> TestDrainingServer is an integration test. It should be a unit test instead
> ---------------------------------------------------------------------------
>
> Key: HBASE-7462
> URL: https://issues.apache.org/jira/browse/HBASE-7462
> Project: HBase
> Issue Type: Wish
> Components: test
> Affects Versions: 0.95.2
> Reporter: Nicolas Liochon
> Assignee: Gustavo Anatoly
> Priority: Trivial
> Labels: noob
> Attachments: 7462.v3.patch, HBASE-7462-v2.patch
>
>
> TestDrainingServer tests the function that allows to say that a regionserver should not get new regions.
> As it is written today, it's an integration test: it starts & stops a cluster.
> The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira