[jira] [Commented] (DRILL-5796) Filter pruning for multi rowgroup parquet file

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-5796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529803#comment-16529803 ] 

ASF GitHub Bot commented on DRILL-5796:
---------------------------------------

jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file
URL: https://github.com/apache/drill/pull/1298#discussion_r199478733
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetComparisonPredicate.java
 ##########
 @@ -83,23 +84,26 @@ private ParquetComparisonPredicate(
    * where Column1 and Column2 are from same parquet table.
    */
   @Override
-  public boolean canDrop(RangeExprEvaluator<C> evaluator) {
+  public RowsMatch matches(RangeExprEvaluator<C> evaluator) {
     Statistics<C> leftStat = left.accept(evaluator, null);
-    if (isNullOrEmpty(leftStat)) {
-      return false;
+    if (isNullOrEmpty(leftStat) || !leftStat.hasNonNullValue()) {
 
 Review comment:
   Done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Filter pruning for multi rowgroup parquet file
> ----------------------------------------------
>
>                 Key: DRILL-5796
>                 URL: https://issues.apache.org/jira/browse/DRILL-5796
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Storage - Parquet
>            Reporter: Damien Profeta
>            Assignee: Jean-Blas IMBERT
>            Priority: Major
>             Fix For: 1.14.0
>
>
> Today, filter pruning use the file name as the partitioning key. This means you can remove a partition only if the whole file is for the same partition. With parquet, you can prune the filter if the rowgroup make a partition of your dataset as the unit of work if the rowgroup not the file.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)