You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/10/22 22:18:51 UTC

Review Request 39569: Added output operator for Executor struct in agent

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39569/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Repository: mesos


Description
-------

See summary. Needed for https://reviews.apache.org/r/38874


Diffs
-----

  src/slave/slave.hpp d81a9c4d09d3f6be417120e412324258f19604a3 
  src/slave/slave.cpp e9f2d1bf7978450f0cd471bdb5606305092fc98a 

Diff: https://reviews.apache.org/r/39569/diff/


Testing
-------


Thanks,

Anand Mazumdar

Re: Review Request 39569: Added output operator for Executor struct in agent

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39569/#review103693
-----------------------------------------------------------

Ship it!


Will land this shortly.


src/slave/slave.hpp (line 698)
<https://reviews.apache.org/r/39569/#comment161761>

    s/ostream/stream/ to be consistent with the others here


- Ben Mahler


On Oct. 22, 2015, 11:26 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39569/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2015, 11:26 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary. Needed for https://reviews.apache.org/r/38874
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp d81a9c4d09d3f6be417120e412324258f19604a3 
>   src/slave/slave.cpp e9f2d1bf7978450f0cd471bdb5606305092fc98a 
> 
> Diff: https://reviews.apache.org/r/39569/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 39569: Added output operator for Executor struct in agent

Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39569/
-----------------------------------------------------------

(Updated Oct. 22, 2015, 11:26 p.m.)


Review request for mesos and Ben Mahler.


Changes
-------

Moved ostream function from Executor struct


Repository: mesos


Description
-------

See summary. Needed for https://reviews.apache.org/r/38874


Diffs (updated)
-----

  src/slave/slave.hpp d81a9c4d09d3f6be417120e412324258f19604a3 
  src/slave/slave.cpp e9f2d1bf7978450f0cd471bdb5606305092fc98a 

Diff: https://reviews.apache.org/r/39569/diff/


Testing
-------


Thanks,

Anand Mazumdar

Re: Review Request 39569: Added output operator for Executor struct in agent

Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39569/
-----------------------------------------------------------

(Updated Oct. 22, 2015, 11:07 p.m.)


Review request for mesos and Ben Mahler.


Changes
-------

Review comments from Neil + Moved the ostream function down


Repository: mesos


Description
-------

See summary. Needed for https://reviews.apache.org/r/38874


Diffs (updated)
-----

  src/slave/slave.hpp d81a9c4d09d3f6be417120e412324258f19604a3 
  src/slave/slave.cpp e9f2d1bf7978450f0cd471bdb5606305092fc98a 

Diff: https://reviews.apache.org/r/39569/diff/


Testing
-------


Thanks,

Anand Mazumdar

Re: Review Request 39569: Added output operator for Executor struct in agent

Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39569/#review103672
-----------------------------------------------------------



src/slave/slave.cpp (line 1974)
<https://reviews.apache.org/r/39569/#comment161740>

    Can we fix the leading whitespace?



src/slave/slave.cpp (line 2135)
<https://reviews.apache.org/r/39569/#comment161741>

    See above.



src/slave/slave.cpp (line 3440)
<https://reviews.apache.org/r/39569/#comment161742>

    See above.


- Neil Conway


On Oct. 22, 2015, 8:18 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39569/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2015, 8:18 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary. Needed for https://reviews.apache.org/r/38874
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp d81a9c4d09d3f6be417120e412324258f19604a3 
>   src/slave/slave.cpp e9f2d1bf7978450f0cd471bdb5606305092fc98a 
> 
> Diff: https://reviews.apache.org/r/39569/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>