You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2011/02/24 20:06:38 UTC
[jira] Created: (CASSANDRA-2243) fix "ant codecoverage"
fix "ant codecoverage"
----------------------
Key: CASSANDRA-2243
URL: https://issues.apache.org/jira/browse/CASSANDRA-2243
Project: Cassandra
Issue Type: Bug
Reporter: Jonathan Ellis
Assignee: Stephen Connolly
Fix For: 0.7.3
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2243) fix "ant codecoverage"
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999870#comment-12999870 ]
Hudson commented on CASSANDRA-2243:
-----------------------------------
Integrated in Cassandra-0.7 #325 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/325/])
fix "ant codecoverage"
patch by Stephen Connolly; tested by jbellis for CASSANDRA-2243
> fix "ant codecoverage"
> ----------------------
>
> Key: CASSANDRA-2243
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2243
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Stephen Connolly
> Labels: build
> Fix For: 0.7.3
>
> Attachments: CASSANDRA-2243.patch
>
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2243) fix "ant codecoverage"
Posted by "Stephen Connolly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephen Connolly updated CASSANDRA-2243:
----------------------------------------
Attachment: CASSANDRA-2243.patch
> fix "ant codecoverage"
> ----------------------
>
> Key: CASSANDRA-2243
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2243
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Stephen Connolly
> Labels: build
> Fix For: 0.7.3
>
> Attachments: CASSANDRA-2243.patch
>
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2243) fix "ant codecoverage"
Posted by "Stephen Connolly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999867#comment-12999867 ]
Stephen Connolly commented on CASSANDRA-2243:
---------------------------------------------
OK, here is my concern.
Prior to this fix, the codecoverage target would only work if you ran something like
ant codecoverage -Dcobertura.dir=/path/to/cobertura.jar
if you just ran
ant codecoverage
then it would fail.
The reasoning behind the above is to ensure that cobertura.jar is never bundled in the -bin.tar.gz or -src.tar.gz that we ship (due to cobertura.jar having GPL code)
With this patch, we never have the risk of bundling cobertura.jar as it remains safely in ~/.m2/repository/net/sourceforge/cobertura/... and never comes near the build directory...
However there is a side-effect, namely now the ant target "test" will always run with cobertura.jar on the classpath.
This should be minimal risk, as you are not bundling the test classpath, but it is up to the Cassandra PMC to decide on that risk as the Cassandra PMC has to approve the releases
> fix "ant codecoverage"
> ----------------------
>
> Key: CASSANDRA-2243
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2243
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Stephen Connolly
> Labels: build
> Fix For: 0.7.3
>
> Attachments: CASSANDRA-2243.patch
>
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2243) fix "ant codecoverage"
Posted by "Stephen Connolly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999865#comment-12999865 ]
Stephen Connolly commented on CASSANDRA-2243:
---------------------------------------------
hmmm the whole way cobertura instrumentation had been implemented is a little messy and with this fix I have concerns about GPL leaking as cobertura is always on the classpath even for non-instrumented tests. I think the testmacro needs to be tweaked
> fix "ant codecoverage"
> ----------------------
>
> Key: CASSANDRA-2243
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2243
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Stephen Connolly
> Labels: build
> Fix For: 0.7.3
>
> Attachments: CASSANDRA-2243.patch
>
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira