You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Phabricator (Updated) (JIRA)" <ji...@apache.org> on 2012/01/28 02:57:11 UTC
[jira] [Updated] (HBASE-5297) Update metrics numOpenConnections and
callQueueLen directly in HBaseServer
[ https://issues.apache.org/jira/browse/HBASE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5297:
-------------------------------
Attachment: HBASE-5297.D1509.1.patch
sc requested code review of "HBASE-5297 [jira] Update metrics numOpenConnections and callQueueLen directly in HBaseServer".
Reviewers: dhruba, tedyu, JIRA
Update metrics numOpenConnections and callQueueLen directly in HBaseServer
This removes the circular dependency of HbaseRpcMetrics and HBaseServer. There
are also two minor changes.
1. Remove unnecessary locking
2. Add metrics for priorityCallQueueLen
It's better to directly update the metrics outside HBaseRpcMetrics so that HBaseRpcMetrics doesn't have to hold reference to HBaseServer.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D1509
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java
src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/3129/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Update metrics numOpenConnections and callQueueLen directly in HBaseServer
> --------------------------------------------------------------------------
>
> Key: HBASE-5297
> URL: https://issues.apache.org/jira/browse/HBASE-5297
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Attachments: HBASE-5297.D1509.1.patch
>
>
> It's better to directly update the metrics outside HBaseRpcMetrics so that HBaseRpcMetrics doesn't have to hold reference to HBaseServer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira