You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/04/21 01:48:01 UTC

[GitHub] [commons-lang] Isira-Seneviratne opened a new pull request #525: Correct Javadocs of methods that use Validate.notNull() and replace some uses of Validate.isTrue() with Validate.notNull().

Isira-Seneviratne opened a new pull request #525:
URL: https://github.com/apache/commons-lang/pull/525


   The Javadocs of some methods that use the Validate.notNull() method incorrectly refer to IllegalArgumentException instead of NullPointerException as the exception thrown, while the methods' tests check for NullPointerException. In addition, some of said methods use Validate.isTrue() instead of Validate.notNull() for null checking.
   
   This PR fixes both issues as they are closely related.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on pull request #525: Correct Javadocs of methods that use Validate.notNull() and replace some uses of Validate.isTrue() with Validate.notNull().

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #525:
URL: https://github.com/apache/commons-lang/pull/525#issuecomment-656162845


   @Isira-Seneviratne 
   May you please rebase on master if still appropriate?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory merged pull request #525: Correct Javadocs of methods that use Validate.notNull() and replace some uses of Validate.isTrue() with Validate.notNull().

Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #525:
URL: https://github.com/apache/commons-lang/pull/525


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] coveralls edited a comment on pull request #525: Correct Javadocs of methods that use Validate.notNull() and replace some uses of Validate.isTrue() with Validate.notNull().

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #525:
URL: https://github.com/apache/commons-lang/pull/525#issuecomment-616961576


   
   [![Coverage Status](https://coveralls.io/builds/31979238/badge)](https://coveralls.io/builds/31979238)
   
   Coverage remained the same at 94.598% when pulling **a6e0946a75295847e3198a7236e53a5be9632cf8 on Isira-Seneviratne:Change_Javadoc_IllegalArgumentException_to_NullPointerException** into **031f4f61b70ec88d16affc982a7092935fd4a0c9 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] coveralls commented on issue #525: Correct Javadocs of methods that use Validate.notNull() and replace some uses of Validate.isTrue() with Validate.notNull().

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #525:
URL: https://github.com/apache/commons-lang/pull/525#issuecomment-616961576


   
   [![Coverage Status](https://coveralls.io/builds/30214870/badge)](https://coveralls.io/builds/30214870)
   
   Coverage remained the same at 95.091% when pulling **e675529b6bac87df86fc9ef95f3af6ebf00e079d on Isira-Seneviratne:Change_Javadoc_IllegalArgumentException_to_NullPointerException** into **f6923510352fc3fbfad68bc6c5ac5258a34671b7 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] Isira-Seneviratne commented on pull request #525: Correct Javadocs of methods that use Validate.notNull() and replace some uses of Validate.isTrue() with Validate.notNull().

Posted by GitBox <gi...@apache.org>.
Isira-Seneviratne commented on pull request #525:
URL: https://github.com/apache/commons-lang/pull/525#issuecomment-656400043


   > 
   > 
   > @Isira-Seneviratne
   > May you please rebase on master if still appropriate?
   
   Of course.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org