You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by CZWin32768 <gi...@git.apache.org> on 2017/12/01 10:15:22 UTC

[GitHub] bigtop pull request #315: BIGTOP-2954: fix bug of do-component-build which m...

GitHub user CZWin32768 opened a pull request:

    https://github.com/apache/bigtop/pull/315

    BIGTOP-2954: fix bug of do-component-build which may cause spark build failure

    The mvn command in the last line of spark/do-component-build uses "mvn", but here should be "./build/mvn".
    make-distribution.sh will only run "mvn clean package", so in order to get the Spark packages installed in the local Maven repository (or to run the tests), we need to run "mvn install" again.
    make-distribution.sh uses "./build/mvn" but in do-component-build "mvn" is used, which may be in wrong version.
    It will cause build failure when a mvn of old version was set in PATH.
    This may cause that "mvn install" build failure after "mvn clean package" build successfully.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/CZWin32768/bigtop master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bigtop/pull/315.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #315
    
----
commit 31f726aa039907cc9809f31a092e1e0331827491
Author: Zewen Chi <cz...@sina.com>
Date:   2017-12-01T10:10:07Z

    BIGTOP-2954: fix bug of do-component-build that may cause spark build failure

----


---

[GitHub] bigtop issue #315: BIGTOP-2954: fix bug of do-component-build which may caus...

Posted by CZWin32768 <gi...@git.apache.org>.
Github user CZWin32768 commented on the issue:

    https://github.com/apache/bigtop/pull/315
  
    Now use --mvn in spark do-component-build to make sure the build environment is aligned across Bigtop builds.


---