You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by chenliang613 <gi...@git.apache.org> on 2017/10/29 19:17:13 UTC
[GitHub] carbondata pull request #1450: [CARBONDATA-1554] Add a new profile spark2.2 ...
GitHub user chenliang613 opened a pull request:
https://github.com/apache/carbondata/pull/1450
[CARBONDATA-1554] Add a new profile spark2.2 in main pom file
Add a new profile spark2.2 in main pom file.
- [X] Any interfaces changed?
NONE
- [X] Any backward compatibility impacted?
NONE
- [X] Document update required?
Not require
- [X] Testing done
- [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chenliang613/carbondata spark2.2_pom
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1450.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1450
----
commit 03f26b6f0dbb2fc1ed65c3fac96e12ff9bc1ccff
Author: chenliang613 <ch...@apache.org>
Date: 2017-10-29T19:14:39Z
[CARBONDATA-1554] Add a new profile spark2.2 in main pom file
----
---
[GitHub] carbondata pull request #1450: [CARBONDATA-1554] Add a new profile spark2.2 ...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1450#discussion_r147619193
--- Diff: pom.xml ---
@@ -515,6 +515,17 @@
</build>
</profile>
<profile>
+ <id>spark-2.2</id>
+ <properties>
+ <spark.version>2.1.0</spark.version>
--- End diff --
It should be 2.2.0
---
[GitHub] carbondata pull request #1450: [CARBONDATA-1554] Add a new profile spark2.2 ...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 closed the pull request at:
https://github.com/apache/carbondata/pull/1450
---
[GitHub] carbondata pull request #1450: [CARBONDATA-1554] Add a new profile spark2.2 ...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1450#discussion_r147647038
--- Diff: pom.xml ---
@@ -515,6 +516,51 @@
</build>
</profile>
<profile>
+ <id>spark-2.2</id>
+ <properties>
+ <spark.version>2.2.0</spark.version>
+ <scala.binary.version>2.11</scala.binary.version>
+ <scala.version>2.11.8</scala.version>
+ </properties>
+ <modules>
+ <module>integration/spark2</module>
+ <module>examples/spark2</module>
--- End diff --
@chenliang613 I have raised a pr to add package integration/spark2.2 and examples/spark2.2, we should change these two lines to spark2.2?
---
[GitHub] carbondata pull request #1450: [CARBONDATA-1554] Add a new profile spark2.2 ...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1450#discussion_r147646408
--- Diff: pom.xml ---
@@ -515,6 +515,17 @@
</build>
</profile>
<profile>
+ <id>spark-2.2</id>
+ <properties>
+ <spark.version>2.1.0</spark.version>
+ <scala.binary.version>2.11</scala.binary.version>
+ <scala.version>2.11.8</scala.version>
--- End diff --
this is not hard code. by default use spark 2.1.0, here should change to 2.2.0
---
[GitHub] carbondata pull request #1450: [CARBONDATA-1554] Add a new profile spark2.2 ...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1450#discussion_r147619175
--- Diff: pom.xml ---
@@ -515,6 +515,17 @@
</build>
</profile>
<profile>
+ <id>spark-2.2</id>
+ <properties>
+ <spark.version>2.1.0</spark.version>
+ <scala.binary.version>2.11</scala.binary.version>
+ <scala.version>2.11.8</scala.version>
--- End diff --
Should not hard code the version
---
[GitHub] carbondata issue #1450: [CARBONDATA-1554] Add a new profile spark2.2 in main...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1450
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/742/
---
[GitHub] carbondata issue #1450: [CARBONDATA-1554] Add a new profile spark2.2 in main...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1450
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1371/
---
[GitHub] carbondata pull request #1450: [CARBONDATA-1554] Add a new profile spark2.2 ...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1450#discussion_r147645857
--- Diff: pom.xml ---
@@ -515,6 +515,17 @@
</build>
</profile>
<profile>
+ <id>spark-2.2</id>
+ <properties>
+ <spark.version>2.1.0</spark.version>
--- End diff --
ok
---
[GitHub] carbondata issue #1450: [CARBONDATA-1554] Add a new profile spark2.2 in main...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1450
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1379/
---
[GitHub] carbondata issue #1450: [CARBONDATA-1554] Add a new profile spark2.2 in main...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1450
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/734/
---
[GitHub] carbondata issue #1450: [CARBONDATA-1554] Add a new profile spark2.2 in main...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1450
already merged to branch spark2.2, so close this pr.
---