You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jared Stewart <js...@pivotal.io> on 2017/07/21 17:36:28 UTC
Review Request 61042: GEODE-3214: Remove support for multistep gfsh
commands.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61042/
-----------------------------------------------------------
Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
Repository: geode
Description
-------
GEODE-3214: Remove support for multistep gfsh commands.
Diffs
-----
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java 5621b2497050d6a1003078dc993861a90fad4000
geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIMultiStepHelper.java 4eeb2279cc041adbd12127a5ad68e862a6e72871
geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIRemoteStep.java 4c38a313f7b6b7244c092dd4363c778bb810e18c
geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIStep.java a037f518a89258bc5e6da00f42f6c7b102bc0e2c
geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIStepExecption.java 389e72f4f91dd8a30e4086391d3c882e003943f3
geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/MultiStepCommand.java 75925f782b54c5d55c8fb921b803cf7ae4443252
geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java 89cb9adee00b72c3775896a5f553256205a0b7cb
geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategy.java 1cbdb157d2e65a5976edd906f9db82272caad4c4
geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java 5e502f55e781a5bf3a656d17d0156175088891b2
geode-core/src/main/java/org/apache/geode/management/internal/web/http/ClientHttpRequest.java 43657b9888d7e588d2d6e55584671478940c1d28
Diff: https://reviews.apache.org/r/61042/diff/1/
Testing
-------
Precheckin running
Thanks,
Jared Stewart
Re: Review Request 61042: GEODE-3214: Remove support for multistep
gfsh commands.
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61042/#review181133
-----------------------------------------------------------
Ship it!
Ship It!
- Jinmei Liao
On July 21, 2017, 5:36 p.m., Jared Stewart wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61042/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 5:36 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-3214: Remove support for multistep gfsh commands.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java 5621b2497050d6a1003078dc993861a90fad4000
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIMultiStepHelper.java 4eeb2279cc041adbd12127a5ad68e862a6e72871
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIRemoteStep.java 4c38a313f7b6b7244c092dd4363c778bb810e18c
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIStep.java a037f518a89258bc5e6da00f42f6c7b102bc0e2c
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIStepExecption.java 389e72f4f91dd8a30e4086391d3c882e003943f3
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/MultiStepCommand.java 75925f782b54c5d55c8fb921b803cf7ae4443252
> geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java 89cb9adee00b72c3775896a5f553256205a0b7cb
> geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategy.java 1cbdb157d2e65a5976edd906f9db82272caad4c4
> geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java 5e502f55e781a5bf3a656d17d0156175088891b2
> geode-core/src/main/java/org/apache/geode/management/internal/web/http/ClientHttpRequest.java 43657b9888d7e588d2d6e55584671478940c1d28
>
>
> Diff: https://reviews.apache.org/r/61042/diff/1/
>
>
> Testing
> -------
>
> Precheckin running
>
>
> Thanks,
>
> Jared Stewart
>
>
Re: Review Request 61042: GEODE-3214: Remove support for multistep
gfsh commands.
Posted by Emily Yeh <ey...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61042/#review181247
-----------------------------------------------------------
Ship it!
+1!
- Emily Yeh
On July 24, 2017, 5:50 p.m., Jared Stewart wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61042/
> -----------------------------------------------------------
>
> (Updated July 24, 2017, 5:50 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-3214: Remove support for multistep gfsh commands.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java 5621b2497050d6a1003078dc993861a90fad4000
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIMultiStepHelper.java 4eeb2279cc041adbd12127a5ad68e862a6e72871
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIRemoteStep.java 4c38a313f7b6b7244c092dd4363c778bb810e18c
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIStep.java a037f518a89258bc5e6da00f42f6c7b102bc0e2c
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIStepExecption.java 389e72f4f91dd8a30e4086391d3c882e003943f3
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/MultiStepCommand.java 75925f782b54c5d55c8fb921b803cf7ae4443252
> geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java 89cb9adee00b72c3775896a5f553256205a0b7cb
> geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategy.java 1cbdb157d2e65a5976edd906f9db82272caad4c4
> geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java 5e502f55e781a5bf3a656d17d0156175088891b2
> geode-core/src/main/java/org/apache/geode/management/internal/web/http/ClientHttpRequest.java 43657b9888d7e588d2d6e55584671478940c1d28
>
>
> Diff: https://reviews.apache.org/r/61042/diff/1/
>
>
> Testing
> -------
>
> Precheckin passed
>
>
> Thanks,
>
> Jared Stewart
>
>
Re: Review Request 61042: GEODE-3214: Remove support for multistep
gfsh commands.
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61042/#review181244
-----------------------------------------------------------
Ship it!
Ship It!
- Jinmei Liao
On July 24, 2017, 5:50 p.m., Jared Stewart wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61042/
> -----------------------------------------------------------
>
> (Updated July 24, 2017, 5:50 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-3214: Remove support for multistep gfsh commands.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java 5621b2497050d6a1003078dc993861a90fad4000
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIMultiStepHelper.java 4eeb2279cc041adbd12127a5ad68e862a6e72871
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIRemoteStep.java 4c38a313f7b6b7244c092dd4363c778bb810e18c
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIStep.java a037f518a89258bc5e6da00f42f6c7b102bc0e2c
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIStepExecption.java 389e72f4f91dd8a30e4086391d3c882e003943f3
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/MultiStepCommand.java 75925f782b54c5d55c8fb921b803cf7ae4443252
> geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java 89cb9adee00b72c3775896a5f553256205a0b7cb
> geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategy.java 1cbdb157d2e65a5976edd906f9db82272caad4c4
> geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java 5e502f55e781a5bf3a656d17d0156175088891b2
> geode-core/src/main/java/org/apache/geode/management/internal/web/http/ClientHttpRequest.java 43657b9888d7e588d2d6e55584671478940c1d28
>
>
> Diff: https://reviews.apache.org/r/61042/diff/1/
>
>
> Testing
> -------
>
> Precheckin passed
>
>
> Thanks,
>
> Jared Stewart
>
>
Re: Review Request 61042: GEODE-3214: Remove support for multistep
gfsh commands.
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61042/
-----------------------------------------------------------
(Updated July 24, 2017, 5:50 p.m.)
Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
Repository: geode
Description
-------
GEODE-3214: Remove support for multistep gfsh commands.
Diffs
-----
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java 5621b2497050d6a1003078dc993861a90fad4000
geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIMultiStepHelper.java 4eeb2279cc041adbd12127a5ad68e862a6e72871
geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIRemoteStep.java 4c38a313f7b6b7244c092dd4363c778bb810e18c
geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIStep.java a037f518a89258bc5e6da00f42f6c7b102bc0e2c
geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIStepExecption.java 389e72f4f91dd8a30e4086391d3c882e003943f3
geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/MultiStepCommand.java 75925f782b54c5d55c8fb921b803cf7ae4443252
geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java 89cb9adee00b72c3775896a5f553256205a0b7cb
geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategy.java 1cbdb157d2e65a5976edd906f9db82272caad4c4
geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java 5e502f55e781a5bf3a656d17d0156175088891b2
geode-core/src/main/java/org/apache/geode/management/internal/web/http/ClientHttpRequest.java 43657b9888d7e588d2d6e55584671478940c1d28
Diff: https://reviews.apache.org/r/61042/diff/1/
Testing (updated)
-------
Precheckin passed
Thanks,
Jared Stewart