You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ephraimbuddy (via GitHub)" <gi...@apache.org> on 2025/11/20 07:46:34 UTC
[PR] More update to the python client release command [airflow]
ephraimbuddy opened a new pull request, #58513:
URL: https://github.com/apache/airflow/pull/58513
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] More update to the python client release command [airflow]
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on code in PR #58513:
URL: https://github.com/apache/airflow/pull/58513#discussion_r2545722104
##########
dev/README_RELEASE_PYTHON_CLIENT.md:
##########
@@ -170,13 +182,19 @@ Then open a PR and merge it into main.
```shell script
cd ${AIRFLOW_REPO_ROOT}
-git tag -s python-client/${VERSION}${VERSION_SUFFIX} -m "Airflow Python Client ${VERSION}${VERSION_SUFFIX}"
-git push apache python-client/${VERSION}${VERSION_SUFFIX}
+git tag -s python-client/${VERSION_RC} -m "Airflow Python Client ${VERSION_RC}"
+git push origin python-client/${VERSION_RC}
Review Comment:
```suggestion
git push apache python-client/${VERSION_RC}
```
##########
dev/README_RELEASE_PYTHON_CLIENT.md:
##########
@@ -156,8 +168,8 @@ cd ${CLIENT_REPO_ROOT}
git diff HEAD
git checkout -b release-${VERSION}
git add .
-git commit -m "Update Python Client to ${VERSION}${VERSION_SUFFIX}"
-git push apache release-${VERSION}
+git commit -m "Update Python Client to ${VERSION_RC}"
+git push origin release-${VERSION}
Review Comment:
```suggestion
git push apache release-${VERSION}
```
##########
dev/README_RELEASE_PYTHON_CLIENT.md:
##########
@@ -170,13 +182,19 @@ Then open a PR and merge it into main.
```shell script
cd ${AIRFLOW_REPO_ROOT}
-git tag -s python-client/${VERSION}${VERSION_SUFFIX} -m "Airflow Python Client ${VERSION}${VERSION_SUFFIX}"
-git push apache python-client/${VERSION}${VERSION_SUFFIX}
+git tag -s python-client/${VERSION_RC} -m "Airflow Python Client ${VERSION_RC}"
+git push origin python-client/${VERSION_RC}
cd ${CLIENT_REPO_ROOT}
-git tag -s ${VERSION}${VERSION_SUFFIX} -m "Airflow Python Client ${VERSION}${VERSION_SUFFIX}"
-git push apache tag ${VERSION}${VERSION_SUFFIX}
+git tag -s ${VERSION_RC} -m "Airflow Python Client ${VERSION_RC}"
+git push origin tag ${VERSION_RC}
Review Comment:
```suggestion
git push apache tag ${VERSION_RC}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] More update to the python client release command [airflow]
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on code in PR #58513:
URL: https://github.com/apache/airflow/pull/58513#discussion_r2545527778
##########
dev/README_RELEASE_PYTHON_CLIENT.md:
##########
@@ -157,7 +168,7 @@ git diff HEAD
git checkout -b release-${VERSION}
git add .
git commit -m "Update Python Client to ${VERSION}${VERSION_SUFFIX}"
-git push apache release-${VERSION}
+git push origin release-${VERSION}
```
Review Comment:
WDYT given the above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] More update to the python client release command [airflow]
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on code in PR #58513:
URL: https://github.com/apache/airflow/pull/58513#discussion_r2545301241
##########
dev/README_RELEASE_PYTHON_CLIENT.md:
##########
@@ -157,7 +168,7 @@ git diff HEAD
git checkout -b release-${VERSION}
git add .
git commit -m "Update Python Client to ${VERSION}${VERSION_SUFFIX}"
-git push apache release-${VERSION}
+git push origin release-${VERSION}
```
Review Comment:
I think we have been using `origin` as remote for releases. Not sure it's written anywhere to use it but if you look at this https://github.com/apache/airflow/blob/v2-4-stable/dev/README_RELEASE_AIRFLOW.md#prepare-the-apache-airflow-package-rc from v2-4 branch before we had a release command, origin was used. Also release command default is origin.
I think we had advocated for release clone to be different from airflow dev clone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] More update to the python client release command [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #58513:
URL: https://github.com/apache/airflow/pull/58513#issuecomment-3558107294
### Backport successfully created: v3-1-test
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>✅</td>
<td>v3-1-test</td>
<td><a href="https://github.com/apache/airflow/pull/58527"><img src="https://img.shields.io/badge/PR-58527-blue" alt="PR Link"></a></td>
</tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] More update to the python client release command [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #58513:
URL: https://github.com/apache/airflow/pull/58513#discussion_r2545060264
##########
dev/README_RELEASE_PYTHON_CLIENT.md:
##########
@@ -202,6 +219,7 @@ svn mkdir ${VERSION}${VERSION_SUFFIX}
# Move the artifacts to svn folder & commit
mv ${AIRFLOW_REPO_ROOT}/dist/apache_airflow_client-* ${VERSION}${VERSION_SUFFIX}/
+mv ${AIRFLOW_REPO_ROOT}/dist/apache_airflow_python_client-* ${VERSION}${VERSION_SUFFIX}/
Review Comment:
We can use VERSION_RC here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] More update to the python client release command [airflow]
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy merged PR #58513:
URL: https://github.com/apache/airflow/pull/58513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] More update to the python client release command [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #58513:
URL: https://github.com/apache/airflow/pull/58513#discussion_r2545053563
##########
dev/README_RELEASE_PYTHON_CLIENT.md:
##########
@@ -157,7 +168,7 @@ git diff HEAD
git checkout -b release-${VERSION}
git add .
git commit -m "Update Python Client to ${VERSION}${VERSION_SUFFIX}"
-git push apache release-${VERSION}
+git push origin release-${VERSION}
```
Review Comment:
I think meany people ehave origin set to their account so far in many of the release commands we had assumption that there is a remote pointing to Apache/airflow - maybe instead of changing we should add prerequisite to create such remote ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] More update to the python client release command [airflow]
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on code in PR #58513:
URL: https://github.com/apache/airflow/pull/58513#discussion_r2544742158
##########
dev/README_RELEASE_PYTHON_CLIENT.md:
##########
@@ -140,8 +153,6 @@ git commit -m "Prepare release ${VERSION}${VERSION_SUFFIX}"
cd ${AIRFLOW_REPO_ROOT}
rm dist/*
breeze release-management prepare-python-client --distribution-format both --python-client-repo "${CLIENT_REPO_ROOT}" --version-suffix ""
-breeze release-management prepare-tarball --tarball-type apache_airflow_python_client --version "${VERSION}" --version-suffix "${VERSION_SUFFIX}"
-
Review Comment:
The source package command is run after creating the tag below. Running it here doesn't work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org