[GitHub] [commons-collections] Claudenw commented on pull request #406: COLLECTIONS-844 - allow counting Bloom filters with cell size other than Integer.SIZE

["Claudenw (via GitHub)" <gi...@apache.org>]

Claudenw commented on PR #406:
URL: https://github.com/apache/commons-collections/pull/406#issuecomment-1638721687

   @aherbert 
   
   Cell is a standard term in the literature.  I am preparing two more pull requests.  
   
   1. A stable Bloom filter (weird beast) that acts sorta like a counting Bloom filter with random deletions.
   2. Another implementation of counting Bloom filter that uses the core classes from stable Bloom filter to implement counting Bloom filters that can use from 1 to 32 bits (1 is a bit ridiculous but it is supported).
   
   Both the new counting implementation and the stable Bloom filter are dependant upon a CellManager class and some supporting classes.  I could present the pull requests in either order, the first one being largish (like the layerd change) with the second being a couple of classes for the specific implementation. 
   
   I can update the current counting Bloom filter with the term "cell", but I would like to keep the terminology.  I thought I had change the method name to `getMaxCount`, I'll figure out where that change went.
   
   Would you be amenable to updating the documentation to refer to cell when we have "bits" that are values more than bits?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org