You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/03/07 00:04:50 UTC

Re: Review Request 28656: Added environment decorator for Slave.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28656/#review75562
-----------------------------------------------------------



src/slave/slave.cpp
<https://reviews.apache.org/r/28656/#comment122747>

    Whoops! Mutating the ExecutorInfo means the master sees a mutated version when it fails over and receives a re-registration message from the slave.
    
    This means that subsequent task launches for the executor are going to fail because the ExecutorInfo comparison fails.
    
    This will block 0.22.0:
    https://issues.apache.org/jira/browse/MESOS-2463


- Ben Mahler


On Jan. 14, 2015, 1:31 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28656/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2015, 1:31 a.m.)
> 
> 
> Review request for mesos and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2060
>     https://issues.apache.org/jira/browse/MESOS-2060
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Similar to label decorator for Master.
> 
> 
> Diffs
> -----
> 
>   src/hook/hook.hpp PRE-CREATION 
>   src/hook/manager.hpp PRE-CREATION 
>   src/hook/manager.cpp PRE-CREATION 
>   src/slave/flags.hpp f1b8dfbb7391167b67a9498561742aa9ab9089a6 
>   src/slave/main.cpp 2ff2b0d186dd63e1437956e98e3682d83f2f5cd6 
>   src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d 
> 
> Diff: https://reviews.apache.org/r/28656/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>