You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2022/04/20 10:53:14 UTC

[GitHub] [plc4x] splatch commented on a diff in pull request #352: "Modbus plus"

splatch commented on code in PR #352:
URL: https://github.com/apache/plc4x/pull/352#discussion_r853998595


##########
protocols/modbus/src/main/resources/protocols/modbus/modbus.mspec:
##########
@@ -416,6 +416,15 @@
         ['WCHAR' List
             [array uint 16 value count 'numberOfValues']
         ]
+        ['STRING','1' STRING
+            [simple vstring '8' value encoding='"UTF-8"']
+        ]
+        ['STRING' List
+            [simple vstring '8 * numberOfValues' value encoding='"UTF-8"']

Review Comment:
   It doesn't make much sense, cause output should be a `String` anyway. What's the point of returning a text in chunks to the caller if it can be merged and read at once beforehand?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org