[GitHub] [incubator-uniffle] cchung100m commented on pull request #1046: [#363] refactor: Make the coordinator client managed by CoordinatorClientFactory singleton

["cchung100m (via GitHub)" <gi...@apache.org>]

cchung100m commented on PR #1046:
URL: https://github.com/apache/incubator-uniffle/pull/1046#issuecomment-1674439224

   Hi @jerqi 
   I am still working on the integration test failure. May I know what is this test actually doing?
   
   https://github.com/apache/incubator-uniffle/blob/13c71438c5fd614cdd08939d160afa722475beee/integration-test/common/src/test/java/org/apache/uniffle/test/CoordinatorAssignmentTest.java#L163
   
   Do we expect the server to change the shuffle nodes to `5`?
   https://github.com/apache/incubator-uniffle/blob/13c71438c5fd614cdd08939d160afa722475beee/integration-test/common/src/test/java/org/apache/uniffle/test/CoordinatorAssignmentTest.java#L178
   
   I am not sure why the `info.getServerToPartitionRanges().keySet().size()` returns `10` here
   https://github.com/apache/incubator-uniffle/blob/13c71438c5fd614cdd08939d160afa722475beee/integration-test/common/src/test/java/org/apache/uniffle/test/CoordinatorAssignmentTest.java#L182


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org