You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2014/09/28 18:48:24 UTC
svn commit: r1628083 - in /subversion/trunk/subversion:
libsvn_fs_fs/cached_data.c libsvn_fs_x/cached_data.c
Author: stefan2
Date: Sun Sep 28 16:48:24 2014
New Revision: 1628083
URL: http://svn.apache.org/r1628083
Log:
* subversion/libsvn_fs_fs/cached_data.c
(svn_fs_fs__rep_chain_length): Explain in more detail why we used a
value of '16' here. No functional change.
* subversion/libsvn_fs_x/cached_data.c
(svn_fs_x__rep_chain_length): Same.
Modified:
subversion/trunk/subversion/libsvn_fs_fs/cached_data.c
subversion/trunk/subversion/libsvn_fs_x/cached_data.c
Modified: subversion/trunk/subversion/libsvn_fs_fs/cached_data.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_fs/cached_data.c?rev=1628083&r1=1628082&r2=1628083&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_fs/cached_data.c (original)
+++ subversion/trunk/subversion/libsvn_fs_fs/cached_data.c Sun Sep 28 16:48:24 2014
@@ -1026,7 +1026,14 @@ svn_fs_fs__rep_chain_length(int *chain_l
/* Clear it the SUBPOOL once in a while. Doing it too frequently
* renders the FILE_HINT ineffective. Doing too infrequently, may
- * leave us with too many open file handles. */
+ * leave us with too many open file handles.
+ *
+ * Note that this is mostly about efficiency, with larger values
+ * being more efficient, and any non-zero value is legal here. When
+ * reading deltified contents, we may keep 10s of rev files open at
+ * the same time and the system has to cope with that. Thus, the
+ * limit of 16 chosen below is in the same ballpark.
+ */
++count;
if (count % 16 == 0)
{
Modified: subversion/trunk/subversion/libsvn_fs_x/cached_data.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_x/cached_data.c?rev=1628083&r1=1628082&r2=1628083&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_x/cached_data.c (original)
+++ subversion/trunk/subversion/libsvn_fs_x/cached_data.c Sun Sep 28 16:48:24 2014
@@ -821,7 +821,14 @@ svn_fs_x__rep_chain_length(int *chain_le
/* Clear it the ITERPOOL once in a while. Doing it too frequently
* renders the FILE_HINT ineffective. Doing too infrequently, may
- * leave us with too many open file handles. */
+ * leave us with too many open file handles.
+ *
+ * Note that this is mostly about efficiency, with larger values
+ * being more efficient, and any non-zero value is legal here. When
+ * reading deltified contents, we may keep 10s of rev files open at
+ * the same time and the system has to cope with that. Thus, the
+ * limit of 16 chosen below is in the same ballpark.
+ */
++count;
if (count % 16 == 0)
{