You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anubhav Jindal (Code Review)" <ge...@cloudera.org> on 2026/06/03 22:10:41 UTC

[Impala-ASF-CR] IMPALA-14975: Add HMS config templating to Helm

Hello Gokul Kolady, Abhishek Rawat, Jason Fehr, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24335

to look at the new patch set (#11).

Change subject: IMPALA-14975: Add HMS config templating to Helm
......................................................................

IMPALA-14975: Add HMS config templating to Helm

Add chart-managed hive-site.xml and a release-scoped ConfigMap template
consumed by Impala and HMS pods.

Template the metastore URI to the release-local HMS service name so chart
deployments avoid static host assumptions.

Add ASF license headers for the newly added chart template file.

Testing:
- helm lint helm/impala
- helm template impala14975-check helm/impala
- kubectl config current-context (k3d-impala-live)
- kubectl create namespace impala-14975-live
- helm upgrade --install impala-14975-live helm/impala -n impala-14975-live --set persistence.accessModes[0]=ReadWriteOnce
- kubectl rollout status deployment/impala-14975-live-impala-{statestored,catalogd,impalad,hms} -n impala-14975-live
- kubectl get pods -n impala-14975-live (all Running/Ready)
- kubectl get configmap impala-14975-live-impala-conf -n impala-14975-live -o jsonpath='{.data.hive-site\.xml}' (contains thrift://impala-14975-live-impala-hms:9083)
- kubectl get deployment impala-14975-live-impala-{statestored,catalogd,impalad,hms} -n impala-14975-live -o yaml (all mount hive-site.xml from conf configmap)

Generated-by: Cursor (GPT-5.3)
Implemented and validated manually; Cursor-assisted.

Change-Id: I04c67c1b8bd7c75f5cf9fb7e86084fcb7dd8db83
Co-authored-by: Cursor <cu...@cursor.com>
---
A helm/impala/files/hive-site.xml
A helm/impala/templates/configmap.yaml
2 files changed, 97 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/24335/11
-- 
To view, visit http://gerrit.cloudera.org:8080/24335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I04c67c1b8bd7c75f5cf9fb7e86084fcb7dd8db83
Gerrit-Change-Number: 24335
Gerrit-PatchSet: 11
Gerrit-Owner: Anubhav Jindal <an...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anubhav Jindal <an...@gmail.com>
Gerrit-Reviewer: Gokul Kolady <go...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>