You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/10/05 03:57:04 UTC
Review Request: MesosNativeLibrary java class loading fix for the native
library.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7455/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, John Sirois, and Vinod Kone.
Description
-------
We discovered this when developing a jenkins plugin, where special sandboxing of the classloader takes place.
This fixes the native library loading in that environment and leaves the tests intact.
In the case of running our java example framework, the thread's context class loader and the MesosNativeLibrary.class class loader were the same. (This is not the case when running our jenkins plugin due to the classloader manipulation taking place there).
Diffs
-----
src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in 354b15b6a25a6087e753bef07b0d5104f0269f87
src/java/jni/convert.cpp 45efa64380f265615b314556f9927b11ad8639e1
Diff: https://reviews.apache.org/r/7455/diff/
Testing
-------
Jenkins plugin + make check.
Thanks,
Ben Mahler
Re: Review Request: MesosNativeLibrary java class loading fix for the native
library.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7455/#review12187
-----------------------------------------------------------
Ship it!
Ship It!
- John Sirois
On Oct. 5, 2012, 1:57 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7455/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2012, 1:57 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, John Sirois, and Vinod Kone.
>
>
> Description
> -------
>
> We discovered this when developing a jenkins plugin, where special sandboxing of the classloader takes place.
> This fixes the native library loading in that environment and leaves the tests intact.
>
> In the case of running our java example framework, the thread's context class loader and the MesosNativeLibrary.class class loader were the same. (This is not the case when running our jenkins plugin due to the classloader manipulation taking place there).
>
>
> Diffs
> -----
>
> src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in 354b15b6a25a6087e753bef07b0d5104f0269f87
> src/java/jni/convert.cpp 45efa64380f265615b314556f9927b11ad8639e1
>
> Diff: https://reviews.apache.org/r/7455/diff/
>
>
> Testing
> -------
>
> Jenkins plugin + make check.
>
>
> Thanks,
>
> Ben Mahler
>
>