You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/12 14:27:26 UTC

[GitHub] [flink] snuyanzin commented on a diff in pull request #18109: [FLINK-25284][Table SQL / API] Add proportion of null values to generate with datagen

snuyanzin commented on code in PR #18109:
URL: https://github.com/apache/flink/pull/18109#discussion_r848504683


##########
flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/factories/DataGenTableSourceFactoryTest.java:
##########
@@ -178,6 +192,10 @@ public void testSource() throws Exception {
             Assert.assertEquals(i + 50, row.getLong(2));
             final TimestampData f3 = row.getTimestamp(3, 3);
             Assert.assertTrue(f3.getMillisecond() >= begin - 5000 && f3.getMillisecond() <= end);
+            final MapData f4 = row.getMap(4);
+            Assert.assertTrue(f4.keyArray().isNullAt(0));

Review Comment:
   rebased and it is already there 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org