You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by sh...@inmobi.com on 2014/06/16 09:36:13 UTC

Review Request 22615: OOZIE-1876 use pom properties rather than specific version numbers in the pom files of hbaselibs, hcataloglibs, sharelib, etc

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22615/
-----------------------------------------------------------

Review request for oozie.


Bugs: OOZIE-1876
    https://issues.apache.org/jira/browse/OOZIE-1876


Repository: oozie-git


Description
-------

1. hadoop/hbase/hcatalog versions configurable
2. Include hadooplibs in final distro
3. Renamed oozie-default.xml in final distro


Diffs
-----

  core/pom.xml c935dd7 
  distro/pom.xml 25370c0 
  examples/pom.xml b70ffec 
  hadooplibs/hadoop-0.23/pom.xml f01975e 
  hadooplibs/hadoop-1/pom.xml 30a5996 
  hadooplibs/hadoop-2/pom.xml a02422a 
  hadooplibs/hadoop-3/pom.xml b63bbe4 
  hadooplibs/hadoop-distcp-0.23/pom.xml 36414ba 
  hadooplibs/hadoop-distcp-1/pom.xml fa21703 
  hadooplibs/hadoop-distcp-2/pom.xml d5d37d6 
  hadooplibs/hadoop-distcp-3/pom.xml 491407e 
  hadooplibs/hadoop-distcp/pom.xml PRE-CREATION 
  hadooplibs/hadoop-libs/pom.xml PRE-CREATION 
  hadooplibs/hadoop-test-0.23/pom.xml b0bef89 
  hadooplibs/hadoop-test-1/pom.xml 3d4b409 
  hadooplibs/hadoop-test-2/pom.xml 944dba4 
  hadooplibs/hadoop-test-3/pom.xml e1a3a93 
  hadooplibs/hadoop-utils-0.23/pom.xml 13e736f 
  hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 07a3c29 
  hadooplibs/hadoop-utils-1/pom.xml 0d10e7a 
  hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 07a3c29 
  hadooplibs/hadoop-utils-2/pom.xml ce6d531 
  hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 07a3c29 
  hadooplibs/hadoop-utils-3/pom.xml 07afb2d 
  hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java db827e5 
  hadooplibs/hadoop-utils/pom.xml PRE-CREATION 
  hadooplibs/hadoop-utils/src/versioned-src/hadoop-1/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java PRE-CREATION 
  hadooplibs/hadoop-utils/src/versioned-src/hadoop-2/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java PRE-CREATION 
  hadooplibs/hadoop-utils/src/versioned-src/hadoop-23/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java PRE-CREATION 
  hadooplibs/hadoop-utils/src/versioned-src/hadoop-3/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java PRE-CREATION 
  hadooplibs/pom.xml 788788c 
  hbaselibs/hbase-0.94/pom.xml 6b2526c 
  hbaselibs/pom.xml 8369121 
  hcataloglibs/hcatalog-0.5/pom.xml 457874d 
  hcataloglibs/hcatalog-0.6/pom.xml 98ae13e 
  hcataloglibs/pom.xml cde7bb9 
  minitest/pom.xml 0a6030f 
  pom.xml b5e0e4e 
  sharelib/distcp/pom.xml 486162a 
  sharelib/hcatalog/pom.xml 4efa5e0 
  sharelib/hive/pom.xml 5ca5cb8 
  sharelib/oozie/pom.xml 22a01b6 
  sharelib/pig/pom.xml 6f99523 
  sharelib/sqoop/pom.xml 8925376 
  sharelib/streaming/pom.xml aceab41 
  src/main/assemblies/distro.xml 8e2bbae 
  src/main/assemblies/hadooplib.xml b32ca82 
  src/main/assemblies/hadooplibs.xml 9884efa 
  src/main/assemblies/hbaselib.xml 6e4db33 
  src/main/assemblies/hbaselibs.xml eb71624 
  src/main/assemblies/hcataloglib.xml 1002308 
  src/main/assemblies/hcataloglibs.xml d00d34b 
  tools/pom.xml 487783d 
  webapp/pom.xml 93cfcef 

Diff: https://reviews.apache.org/r/22615/diff/


Testing
-------

Clean build with different hadoop profiles, verified distro that it contains the same files as before


Thanks,

shwethags


Re: Review Request 22615: OOZIE-1876 use pom properties rather than specific version numbers in the pom files of hbaselibs, hcataloglibs, sharelib, etc

Posted by sh...@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22615/
-----------------------------------------------------------

(Updated Dec. 26, 2014, 9:07 a.m.)


Review request for oozie.


Changes
-------

Fixed trailing space and fixed test failures


Bugs: OOZIE-1876
    https://issues.apache.org/jira/browse/OOZIE-1876


Repository: oozie-git


Description
-------

1. hbase/hcatalog versions configurable
2. Include hcatalog libs in final distro


Diffs (updated)
-----

  client/src/main/bin/oozie 44943fa 
  core/pom.xml ca40e2e 
  distro/src/main/bin/oozie-setup.sh 45f21de 
  distro/src/main/bin/oozied.sh 8eafc96 
  docs/src/site/twiki/DG_QuickStart.twiki 526fbc3 
  docs/src/site/twiki/ENG_Building.twiki 8d74b72 
  examples/pom.xml 852d222 
  hadooplibs/hadoop-0.23/pom.xml 6297dbd 
  hadooplibs/hadoop-1/pom.xml f0a32a5 
  hadooplibs/hadoop-2/pom.xml 32d4b6c 
  hadooplibs/hadoop-3/pom.xml 4fd8f29 
  hadooplibs/hadoop-auth-0.23/pom.xml 59cc7f1 
  hadooplibs/hadoop-auth-1/pom.xml 7da7639 
  hadooplibs/hadoop-auth-2/pom.xml cbdb523 
  hadooplibs/hadoop-distcp-0.23/pom.xml 6e42986 
  hadooplibs/hadoop-distcp-1/pom.xml 01eb123 
  hadooplibs/hadoop-distcp-2/pom.xml 7971eb5 
  hadooplibs/hadoop-distcp-3/pom.xml 598ee13 
  hadooplibs/hadoop-test-0.23/pom.xml addcd11 
  hadooplibs/hadoop-test-1/pom.xml baf5a4c 
  hadooplibs/hadoop-test-2/pom.xml 027c813 
  hadooplibs/hadoop-test-3/pom.xml 7176f51 
  hadooplibs/hadoop-utils-0.23/pom.xml 91985fc 
  hadooplibs/hadoop-utils-1/pom.xml c81ea91 
  hadooplibs/hadoop-utils-2/pom.xml 2d3dbdd 
  hadooplibs/hadoop-utils-3/pom.xml 7270bfd 
  hadooplibs/pom.xml e5ea2e7 
  hbaselibs/hbase-0.94/pom.xml a65904e 
  hbaselibs/pom.xml 24051c5 
  hcataloglibs/hive-hcatalog-0.13.1/pom.xml b738741 
  hcataloglibs/pom.xml a96806b 
  minitest/pom.xml 8f656d2 
  pom.xml 9fa81e2 
  sharelib/distcp/pom.xml b788ed0 
  sharelib/hcatalog/pom.xml b934be1 
  sharelib/hive/pom.xml ea088ff 
  sharelib/hive2/pom.xml e4c2465 
  sharelib/oozie/pom.xml 053cf1c 
  sharelib/pig/pom.xml ce75c68 
  sharelib/spark/pom.xml 744c95c 
  sharelib/sqoop/pom.xml 09f0b66 
  sharelib/streaming/pom.xml 50d15f7 
  src/main/assemblies/distro.xml 8e2bbae 
  src/main/assemblies/hadooplib.xml b32ca82 
  src/main/assemblies/hadooplibs.xml 9884efa 
  src/main/assemblies/hbaselib.xml 6e4db33 
  src/main/assemblies/hbaselibs.xml eb71624 
  src/main/assemblies/hcataloglib.xml 1002308 
  src/main/assemblies/hcataloglibs.xml 3d32a8f 
  tools/pom.xml 80fa425 
  tools/src/main/bin/ooziedb.sh 68158d8 
  tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java ca80d35 
  webapp/pom.xml a410b10 
  zookeeper-security-tests/pom.xml b24ce33 

Diff: https://reviews.apache.org/r/22615/diff/


Testing
-------

Clean build with different hive and hbase versions


Thanks,

shwethags


Re: Review Request 22615: OOZIE-1876 use pom properties rather than specific version numbers in the pom files of hbaselibs, hcataloglibs, sharelib, etc

Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22615/
-----------------------------------------------------------

(Updated Dec. 9, 2014, 12:01 p.m.)


Review request for oozie.


Changes
-------

Added profile for bundling hadoop & hcat libraries


Bugs: OOZIE-1876
    https://issues.apache.org/jira/browse/OOZIE-1876


Repository: oozie-git


Description
-------

1. hbase/hcatalog versions configurable
2. Include hcatalog libs in final distro


Diffs (updated)
-----

  client/src/main/bin/oozie 44943fa 
  core/pom.xml ca40e2e 
  core/src/main/conf/hadoop-conf/core-site.xml 35078c7 
  core/src/main/conf/hadoop-conf/core-site.xml.template PRE-CREATION 
  core/src/test/java/org/apache/oozie/test/XTestCase.java 27cbdc9 
  distro/src/main/bin/oozie-setup.sh 45f21de 
  distro/src/main/bin/oozied.sh 8eafc96 
  docs/src/site/twiki/DG_QuickStart.twiki 526fbc3 
  docs/src/site/twiki/ENG_Building.twiki 8d74b72 
  examples/pom.xml 852d222 
  hadooplibs/hadoop-0.23/pom.xml 6297dbd 
  hadooplibs/hadoop-1/pom.xml f0a32a5 
  hadooplibs/hadoop-2/pom.xml 32d4b6c 
  hadooplibs/hadoop-3/pom.xml 4fd8f29 
  hadooplibs/hadoop-auth-0.23/pom.xml 59cc7f1 
  hadooplibs/hadoop-auth-1/pom.xml 7da7639 
  hadooplibs/hadoop-auth-2/pom.xml cbdb523 
  hadooplibs/hadoop-distcp-0.23/pom.xml 6e42986 
  hadooplibs/hadoop-distcp-1/pom.xml 01eb123 
  hadooplibs/hadoop-distcp-2/pom.xml 7971eb5 
  hadooplibs/hadoop-distcp-3/pom.xml 598ee13 
  hadooplibs/hadoop-test-0.23/pom.xml addcd11 
  hadooplibs/hadoop-test-1/pom.xml baf5a4c 
  hadooplibs/hadoop-test-2/pom.xml 027c813 
  hadooplibs/hadoop-test-3/pom.xml 7176f51 
  hadooplibs/hadoop-utils-0.23/pom.xml 91985fc 
  hadooplibs/hadoop-utils-1/pom.xml c81ea91 
  hadooplibs/hadoop-utils-2/pom.xml 2d3dbdd 
  hadooplibs/hadoop-utils-3/pom.xml 7270bfd 
  hadooplibs/pom.xml e5ea2e7 
  hbaselibs/hbase-0.94/pom.xml a65904e 
  hbaselibs/pom.xml 24051c5 
  hcataloglibs/hive-hcatalog-0.13.1/pom.xml b738741 
  hcataloglibs/pom.xml a96806b 
  minitest/pom.xml 8f656d2 
  pom.xml 5507381 
  sharelib/distcp/pom.xml b788ed0 
  sharelib/hcatalog/pom.xml b934be1 
  sharelib/hive/pom.xml ea088ff 
  sharelib/hive2/pom.xml e4c2465 
  sharelib/oozie/pom.xml 053cf1c 
  sharelib/pig/pom.xml ce75c68 
  sharelib/spark/pom.xml 744c95c 
  sharelib/sqoop/pom.xml 09f0b66 
  sharelib/streaming/pom.xml 50d15f7 
  src/main/assemblies/distro.xml 8e2bbae 
  src/main/assemblies/hadooplib.xml b32ca82 
  src/main/assemblies/hadooplibs.xml 9884efa 
  src/main/assemblies/hbaselib.xml 6e4db33 
  src/main/assemblies/hbaselibs.xml eb71624 
  src/main/assemblies/hcataloglib.xml 1002308 
  src/main/assemblies/hcataloglibs.xml 3d32a8f 
  tools/pom.xml 80fa425 
  tools/src/main/bin/ooziedb.sh 68158d8 
  tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java ca80d35 
  webapp/pom.xml a410b10 
  zookeeper-security-tests/pom.xml b24ce33 

Diff: https://reviews.apache.org/r/22615/diff/


Testing
-------

Clean build with different hive and hbase versions


Thanks,

shwethags


Re: Review Request 22615: OOZIE-1876 use pom properties rather than specific version numbers in the pom files of hbaselibs, hcataloglibs, sharelib, etc

Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22615/
-----------------------------------------------------------

(Updated Nov. 27, 2014, 1:04 p.m.)


Review request for oozie.


Changes
-------

verified the sharelibs. All sharelibs look the same except for pig. For pig, I verified with a pig job and works fine.


Bugs: OOZIE-1876
    https://issues.apache.org/jira/browse/OOZIE-1876


Repository: oozie-git


Description
-------

1. hbase/hcatalog versions configurable
2. Include hcatalog libs in final distro


Diffs (updated)
-----

  client/src/main/bin/oozie 44943fa 
  core/pom.xml ca40e2e 
  core/src/main/conf/hadoop-conf/core-site.xml 35078c7 
  core/src/main/conf/hadoop-conf/core-site.xml.template PRE-CREATION 
  core/src/test/java/org/apache/oozie/test/XTestCase.java 27cbdc9 
  distro/src/main/bin/oozie-setup.sh 45f21de 
  distro/src/main/bin/oozied.sh 8eafc96 
  docs/src/site/twiki/DG_QuickStart.twiki 526fbc3 
  docs/src/site/twiki/ENG_Building.twiki 8d74b72 
  examples/pom.xml 852d222 
  hadooplibs/hadoop-0.23/pom.xml 6297dbd 
  hadooplibs/hadoop-1/pom.xml f0a32a5 
  hadooplibs/hadoop-2/pom.xml 32d4b6c 
  hadooplibs/hadoop-3/pom.xml 4fd8f29 
  hadooplibs/hadoop-auth-0.23/pom.xml 59cc7f1 
  hadooplibs/hadoop-auth-1/pom.xml 7da7639 
  hadooplibs/hadoop-auth-2/pom.xml cbdb523 
  hadooplibs/hadoop-distcp-0.23/pom.xml 6e42986 
  hadooplibs/hadoop-distcp-1/pom.xml 01eb123 
  hadooplibs/hadoop-distcp-2/pom.xml 7971eb5 
  hadooplibs/hadoop-distcp-3/pom.xml 598ee13 
  hadooplibs/hadoop-test-0.23/pom.xml addcd11 
  hadooplibs/hadoop-test-1/pom.xml baf5a4c 
  hadooplibs/hadoop-test-2/pom.xml 027c813 
  hadooplibs/hadoop-test-3/pom.xml 7176f51 
  hadooplibs/hadoop-utils-0.23/pom.xml 91985fc 
  hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 46c2fbd 
  hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java 9a19770 
  hadooplibs/hadoop-utils-1/pom.xml c81ea91 
  hadooplibs/hadoop-utils-2/pom.xml 2d3dbdd 
  hadooplibs/hadoop-utils-3/pom.xml 7270bfd 
  hadooplibs/pom.xml e5ea2e7 
  hbaselibs/hbase-0.94/pom.xml a65904e 
  hbaselibs/pom.xml 24051c5 
  hcataloglibs/hive-hcatalog-0.13.1/pom.xml b738741 
  hcataloglibs/pom.xml a96806b 
  minitest/pom.xml 8f656d2 
  pom.xml 5507381 
  sharelib/distcp/pom.xml b788ed0 
  sharelib/hcatalog/pom.xml b934be1 
  sharelib/hive/pom.xml ea088ff 
  sharelib/hive2/pom.xml e4c2465 
  sharelib/oozie/pom.xml 053cf1c 
  sharelib/pig/pom.xml ce75c68 
  sharelib/spark/pom.xml 744c95c 
  sharelib/sqoop/pom.xml 09f0b66 
  sharelib/streaming/pom.xml 50d15f7 
  src/main/assemblies/distro.xml 8e2bbae 
  src/main/assemblies/hadooplib.xml b32ca82 
  src/main/assemblies/hadooplibs.xml 9884efa 
  src/main/assemblies/hbaselib.xml 6e4db33 
  src/main/assemblies/hbaselibs.xml eb71624 
  src/main/assemblies/hcataloglib.xml 1002308 
  src/main/assemblies/hcataloglibs.xml 3d32a8f 
  tools/pom.xml 80fa425 
  tools/src/main/bin/ooziedb.sh 68158d8 
  tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java ca80d35 
  webapp/pom.xml a410b10 
  zookeeper-security-tests/pom.xml b24ce33 

Diff: https://reviews.apache.org/r/22615/diff/


Testing
-------

Clean build with different hive and hbase versions


Thanks,

shwethags


Re: Review Request 22615: OOZIE-1876 use pom properties rather than specific version numbers in the pom files of hbaselibs, hcataloglibs, sharelib, etc

Posted by Robert Kanter <rk...@cloudera.com>.

> On Nov. 26, 2014, 11:12 p.m., Robert Kanter wrote:
> > This is really good.  I think this will help make the build more flexible.  And I know working on it was probably not the most fun thing to do :)
> > 
> > I took a quick look through the patch.  
> > In addition to my two comments on the patch, I have one other concern: the patch changes a lot of the sharelib pom files.  We need to make sure that either the sharelibs each contain the exact set of jars they did before or that any changes in jars do not break any actions.  The former is probably easier because you don't have to do lots of testing beyond making sure the jars are there.  Can you look into this?

One other thing; I don't have time right now to try this out, but I'll try to do it next week.


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22615/#review63153
-----------------------------------------------------------


On Nov. 26, 2014, 6:45 a.m., shwethags wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22615/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2014, 6:45 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1876
>     https://issues.apache.org/jira/browse/OOZIE-1876
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> 1. hbase/hcatalog versions configurable
> 2. Include hcatalog libs in final distro
> 
> 
> Diffs
> -----
> 
>   client/pom.xml 365276d 
>   client/src/main/bin/oozie 44943fa 
>   core/pom.xml ca40e2e 
>   distro/src/main/bin/oozied.sh 8eafc96 
>   docs/src/site/twiki/DG_QuickStart.twiki 526fbc3 
>   docs/src/site/twiki/ENG_Building.twiki 8d74b72 
>   examples/pom.xml 852d222 
>   hadooplibs/hadoop-0.23/pom.xml 6297dbd 
>   hadooplibs/hadoop-1/pom.xml f0a32a5 
>   hadooplibs/hadoop-2/pom.xml 32d4b6c 
>   hadooplibs/hadoop-3/pom.xml 4fd8f29 
>   hadooplibs/hadoop-auth-0.23/pom.xml 59cc7f1 
>   hadooplibs/hadoop-auth-1/pom.xml 7da7639 
>   hadooplibs/hadoop-auth-2/pom.xml cbdb523 
>   hadooplibs/hadoop-distcp-0.23/pom.xml 6e42986 
>   hadooplibs/hadoop-distcp-1/pom.xml 01eb123 
>   hadooplibs/hadoop-distcp-2/pom.xml 7971eb5 
>   hadooplibs/hadoop-distcp-3/pom.xml 598ee13 
>   hadooplibs/hadoop-test-0.23/pom.xml addcd11 
>   hadooplibs/hadoop-test-1/pom.xml baf5a4c 
>   hadooplibs/hadoop-test-2/pom.xml 027c813 
>   hadooplibs/hadoop-test-3/pom.xml 7176f51 
>   hadooplibs/hadoop-utils-0.23/pom.xml 91985fc 
>   hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 46c2fbd 
>   hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java 9a19770 
>   hadooplibs/hadoop-utils-1/pom.xml c81ea91 
>   hadooplibs/hadoop-utils-2/pom.xml 2d3dbdd 
>   hadooplibs/hadoop-utils-3/pom.xml 7270bfd 
>   hadooplibs/pom.xml e5ea2e7 
>   hbaselibs/hbase-0.94/pom.xml a65904e 
>   hbaselibs/pom.xml 24051c5 
>   hcataloglibs/hive-hcatalog-0.13.1/pom.xml b738741 
>   hcataloglibs/pom.xml a96806b 
>   minitest/pom.xml 8f656d2 
>   pom.xml 5507381 
>   sharelib/distcp/pom.xml b788ed0 
>   sharelib/hcatalog/pom.xml b934be1 
>   sharelib/hive/pom.xml ea088ff 
>   sharelib/hive2/pom.xml e4c2465 
>   sharelib/oozie/pom.xml 053cf1c 
>   sharelib/pig/pom.xml ce75c68 
>   sharelib/spark/pom.xml 744c95c 
>   sharelib/sqoop/pom.xml 09f0b66 
>   sharelib/streaming/pom.xml 50d15f7 
>   src/main/assemblies/distro.xml 8e2bbae 
>   src/main/assemblies/hadooplib.xml b32ca82 
>   src/main/assemblies/hadooplibs.xml 9884efa 
>   src/main/assemblies/hbaselib.xml 6e4db33 
>   src/main/assemblies/hbaselibs.xml eb71624 
>   src/main/assemblies/hcataloglib.xml 1002308 
>   src/main/assemblies/hcataloglibs.xml 3d32a8f 
>   tools/pom.xml 80fa425 
>   tools/src/main/bin/ooziedb.sh 68158d8 
>   webapp/pom.xml a410b10 
>   zookeeper-security-tests/pom.xml b24ce33 
> 
> Diff: https://reviews.apache.org/r/22615/diff/
> 
> 
> Testing
> -------
> 
> Clean build with different hive and hbase versions
> 
> 
> Thanks,
> 
> shwethags
> 
>


Re: Review Request 22615: OOZIE-1876 use pom properties rather than specific version numbers in the pom files of hbaselibs, hcataloglibs, sharelib, etc

Posted by sh...@inmobi.com.

> On Nov. 26, 2014, 11:12 p.m., Robert Kanter wrote:
> > This is really good.  I think this will help make the build more flexible.  And I know working on it was probably not the most fun thing to do :)
> > 
> > I took a quick look through the patch.  
> > In addition to my two comments on the patch, I have one other concern: the patch changes a lot of the sharelib pom files.  We need to make sure that either the sharelibs each contain the exact set of jars they did before or that any changes in jars do not break any actions.  The former is probably easier because you don't have to do lots of testing beyond making sure the jars are there.  Can you look into this?
> 
> Robert Kanter wrote:
>     One other thing; I don't have time right now to try this out, but I'll try to do it next week.

Ok. Will check the sharelib


> On Nov. 26, 2014, 11:12 p.m., Robert Kanter wrote:
> > pom.xml, line 94
> > <https://reviews.apache.org/r/22615/diff/7/?file=776596#file776596line94>
> >
> >     There is no hadoop-auth for Hadoop 1.x; IIRC, we currently bundle hadoop-auth from 2.0.2-alpha when compiling against Hadoop 1.x.  Have you tried compiling against Hadoop 1?
> >     
> >     If there isn't a way to reconcile this, we may have to hold your patch back until we drop Hadoop 1 support (at least in trunk), which there has been talk of before.

hadoop-1 uses hadoop-core for auth. See hadoop-auth-1/pom.xml


> On Nov. 26, 2014, 11:12 p.m., Robert Kanter wrote:
> > tools/src/main/bin/ooziedb.sh, lines 44-52
> > <https://reviews.apache.org/r/22615/diff/7/?file=776614#file776614line44>
> >
> >     I think the 'oozie-setup.sh sharelib' command will need something like this too, right?

I think so. Will fix it


- shwethags


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22615/#review63153
-----------------------------------------------------------


On Nov. 26, 2014, 6:45 a.m., shwethags wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22615/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2014, 6:45 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1876
>     https://issues.apache.org/jira/browse/OOZIE-1876
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> 1. hbase/hcatalog versions configurable
> 2. Include hcatalog libs in final distro
> 
> 
> Diffs
> -----
> 
>   client/pom.xml 365276d 
>   client/src/main/bin/oozie 44943fa 
>   core/pom.xml ca40e2e 
>   distro/src/main/bin/oozied.sh 8eafc96 
>   docs/src/site/twiki/DG_QuickStart.twiki 526fbc3 
>   docs/src/site/twiki/ENG_Building.twiki 8d74b72 
>   examples/pom.xml 852d222 
>   hadooplibs/hadoop-0.23/pom.xml 6297dbd 
>   hadooplibs/hadoop-1/pom.xml f0a32a5 
>   hadooplibs/hadoop-2/pom.xml 32d4b6c 
>   hadooplibs/hadoop-3/pom.xml 4fd8f29 
>   hadooplibs/hadoop-auth-0.23/pom.xml 59cc7f1 
>   hadooplibs/hadoop-auth-1/pom.xml 7da7639 
>   hadooplibs/hadoop-auth-2/pom.xml cbdb523 
>   hadooplibs/hadoop-distcp-0.23/pom.xml 6e42986 
>   hadooplibs/hadoop-distcp-1/pom.xml 01eb123 
>   hadooplibs/hadoop-distcp-2/pom.xml 7971eb5 
>   hadooplibs/hadoop-distcp-3/pom.xml 598ee13 
>   hadooplibs/hadoop-test-0.23/pom.xml addcd11 
>   hadooplibs/hadoop-test-1/pom.xml baf5a4c 
>   hadooplibs/hadoop-test-2/pom.xml 027c813 
>   hadooplibs/hadoop-test-3/pom.xml 7176f51 
>   hadooplibs/hadoop-utils-0.23/pom.xml 91985fc 
>   hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 46c2fbd 
>   hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java 9a19770 
>   hadooplibs/hadoop-utils-1/pom.xml c81ea91 
>   hadooplibs/hadoop-utils-2/pom.xml 2d3dbdd 
>   hadooplibs/hadoop-utils-3/pom.xml 7270bfd 
>   hadooplibs/pom.xml e5ea2e7 
>   hbaselibs/hbase-0.94/pom.xml a65904e 
>   hbaselibs/pom.xml 24051c5 
>   hcataloglibs/hive-hcatalog-0.13.1/pom.xml b738741 
>   hcataloglibs/pom.xml a96806b 
>   minitest/pom.xml 8f656d2 
>   pom.xml 5507381 
>   sharelib/distcp/pom.xml b788ed0 
>   sharelib/hcatalog/pom.xml b934be1 
>   sharelib/hive/pom.xml ea088ff 
>   sharelib/hive2/pom.xml e4c2465 
>   sharelib/oozie/pom.xml 053cf1c 
>   sharelib/pig/pom.xml ce75c68 
>   sharelib/spark/pom.xml 744c95c 
>   sharelib/sqoop/pom.xml 09f0b66 
>   sharelib/streaming/pom.xml 50d15f7 
>   src/main/assemblies/distro.xml 8e2bbae 
>   src/main/assemblies/hadooplib.xml b32ca82 
>   src/main/assemblies/hadooplibs.xml 9884efa 
>   src/main/assemblies/hbaselib.xml 6e4db33 
>   src/main/assemblies/hbaselibs.xml eb71624 
>   src/main/assemblies/hcataloglib.xml 1002308 
>   src/main/assemblies/hcataloglibs.xml 3d32a8f 
>   tools/pom.xml 80fa425 
>   tools/src/main/bin/ooziedb.sh 68158d8 
>   webapp/pom.xml a410b10 
>   zookeeper-security-tests/pom.xml b24ce33 
> 
> Diff: https://reviews.apache.org/r/22615/diff/
> 
> 
> Testing
> -------
> 
> Clean build with different hive and hbase versions
> 
> 
> Thanks,
> 
> shwethags
> 
>


Re: Review Request 22615: OOZIE-1876 use pom properties rather than specific version numbers in the pom files of hbaselibs, hcataloglibs, sharelib, etc

Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22615/#review63153
-----------------------------------------------------------


This is really good.  I think this will help make the build more flexible.  And I know working on it was probably not the most fun thing to do :)

I took a quick look through the patch.  
In addition to my two comments on the patch, I have one other concern: the patch changes a lot of the sharelib pom files.  We need to make sure that either the sharelibs each contain the exact set of jars they did before or that any changes in jars do not break any actions.  The former is probably easier because you don't have to do lots of testing beyond making sure the jars are there.  Can you look into this?


pom.xml
<https://reviews.apache.org/r/22615/#comment105344>

    There is no hadoop-auth for Hadoop 1.x; IIRC, we currently bundle hadoop-auth from 2.0.2-alpha when compiling against Hadoop 1.x.  Have you tried compiling against Hadoop 1?
    
    If there isn't a way to reconcile this, we may have to hold your patch back until we drop Hadoop 1 support (at least in trunk), which there has been talk of before.



tools/src/main/bin/ooziedb.sh
<https://reviews.apache.org/r/22615/#comment105345>

    I think the 'oozie-setup.sh sharelib' command will need something like this too, right?


- Robert Kanter


On Nov. 26, 2014, 6:45 a.m., shwethags wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22615/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2014, 6:45 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1876
>     https://issues.apache.org/jira/browse/OOZIE-1876
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> 1. hbase/hcatalog versions configurable
> 2. Include hcatalog libs in final distro
> 
> 
> Diffs
> -----
> 
>   client/pom.xml 365276d 
>   client/src/main/bin/oozie 44943fa 
>   core/pom.xml ca40e2e 
>   distro/src/main/bin/oozied.sh 8eafc96 
>   docs/src/site/twiki/DG_QuickStart.twiki 526fbc3 
>   docs/src/site/twiki/ENG_Building.twiki 8d74b72 
>   examples/pom.xml 852d222 
>   hadooplibs/hadoop-0.23/pom.xml 6297dbd 
>   hadooplibs/hadoop-1/pom.xml f0a32a5 
>   hadooplibs/hadoop-2/pom.xml 32d4b6c 
>   hadooplibs/hadoop-3/pom.xml 4fd8f29 
>   hadooplibs/hadoop-auth-0.23/pom.xml 59cc7f1 
>   hadooplibs/hadoop-auth-1/pom.xml 7da7639 
>   hadooplibs/hadoop-auth-2/pom.xml cbdb523 
>   hadooplibs/hadoop-distcp-0.23/pom.xml 6e42986 
>   hadooplibs/hadoop-distcp-1/pom.xml 01eb123 
>   hadooplibs/hadoop-distcp-2/pom.xml 7971eb5 
>   hadooplibs/hadoop-distcp-3/pom.xml 598ee13 
>   hadooplibs/hadoop-test-0.23/pom.xml addcd11 
>   hadooplibs/hadoop-test-1/pom.xml baf5a4c 
>   hadooplibs/hadoop-test-2/pom.xml 027c813 
>   hadooplibs/hadoop-test-3/pom.xml 7176f51 
>   hadooplibs/hadoop-utils-0.23/pom.xml 91985fc 
>   hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 46c2fbd 
>   hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java 9a19770 
>   hadooplibs/hadoop-utils-1/pom.xml c81ea91 
>   hadooplibs/hadoop-utils-2/pom.xml 2d3dbdd 
>   hadooplibs/hadoop-utils-3/pom.xml 7270bfd 
>   hadooplibs/pom.xml e5ea2e7 
>   hbaselibs/hbase-0.94/pom.xml a65904e 
>   hbaselibs/pom.xml 24051c5 
>   hcataloglibs/hive-hcatalog-0.13.1/pom.xml b738741 
>   hcataloglibs/pom.xml a96806b 
>   minitest/pom.xml 8f656d2 
>   pom.xml 5507381 
>   sharelib/distcp/pom.xml b788ed0 
>   sharelib/hcatalog/pom.xml b934be1 
>   sharelib/hive/pom.xml ea088ff 
>   sharelib/hive2/pom.xml e4c2465 
>   sharelib/oozie/pom.xml 053cf1c 
>   sharelib/pig/pom.xml ce75c68 
>   sharelib/spark/pom.xml 744c95c 
>   sharelib/sqoop/pom.xml 09f0b66 
>   sharelib/streaming/pom.xml 50d15f7 
>   src/main/assemblies/distro.xml 8e2bbae 
>   src/main/assemblies/hadooplib.xml b32ca82 
>   src/main/assemblies/hadooplibs.xml 9884efa 
>   src/main/assemblies/hbaselib.xml 6e4db33 
>   src/main/assemblies/hbaselibs.xml eb71624 
>   src/main/assemblies/hcataloglib.xml 1002308 
>   src/main/assemblies/hcataloglibs.xml 3d32a8f 
>   tools/pom.xml 80fa425 
>   tools/src/main/bin/ooziedb.sh 68158d8 
>   webapp/pom.xml a410b10 
>   zookeeper-security-tests/pom.xml b24ce33 
> 
> Diff: https://reviews.apache.org/r/22615/diff/
> 
> 
> Testing
> -------
> 
> Clean build with different hive and hbase versions
> 
> 
> Thanks,
> 
> shwethags
> 
>


Re: Review Request 22615: OOZIE-1876 use pom properties rather than specific version numbers in the pom files of hbaselibs, hcataloglibs, sharelib, etc

Posted by Jaydeep Vishwakarma <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22615/#review63184
-----------------------------------------------------------



pom.xml
<https://reviews.apache.org/r/22615/#comment105372>

    Some problem with this. 
    All 3 profiles have same number of properties. If hadoop-0.23 has defined here other properties should also be here. 
    This property is overwriting by above defined property. 
    Keeping same variable two places can cause of inconsistency.


- Jaydeep Vishwakarma


On Nov. 26, 2014, 6:45 a.m., shwethags wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22615/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2014, 6:45 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1876
>     https://issues.apache.org/jira/browse/OOZIE-1876
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> 1. hbase/hcatalog versions configurable
> 2. Include hcatalog libs in final distro
> 
> 
> Diffs
> -----
> 
>   client/pom.xml 365276d 
>   client/src/main/bin/oozie 44943fa 
>   core/pom.xml ca40e2e 
>   distro/src/main/bin/oozied.sh 8eafc96 
>   docs/src/site/twiki/DG_QuickStart.twiki 526fbc3 
>   docs/src/site/twiki/ENG_Building.twiki 8d74b72 
>   examples/pom.xml 852d222 
>   hadooplibs/hadoop-0.23/pom.xml 6297dbd 
>   hadooplibs/hadoop-1/pom.xml f0a32a5 
>   hadooplibs/hadoop-2/pom.xml 32d4b6c 
>   hadooplibs/hadoop-3/pom.xml 4fd8f29 
>   hadooplibs/hadoop-auth-0.23/pom.xml 59cc7f1 
>   hadooplibs/hadoop-auth-1/pom.xml 7da7639 
>   hadooplibs/hadoop-auth-2/pom.xml cbdb523 
>   hadooplibs/hadoop-distcp-0.23/pom.xml 6e42986 
>   hadooplibs/hadoop-distcp-1/pom.xml 01eb123 
>   hadooplibs/hadoop-distcp-2/pom.xml 7971eb5 
>   hadooplibs/hadoop-distcp-3/pom.xml 598ee13 
>   hadooplibs/hadoop-test-0.23/pom.xml addcd11 
>   hadooplibs/hadoop-test-1/pom.xml baf5a4c 
>   hadooplibs/hadoop-test-2/pom.xml 027c813 
>   hadooplibs/hadoop-test-3/pom.xml 7176f51 
>   hadooplibs/hadoop-utils-0.23/pom.xml 91985fc 
>   hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 46c2fbd 
>   hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java 9a19770 
>   hadooplibs/hadoop-utils-1/pom.xml c81ea91 
>   hadooplibs/hadoop-utils-2/pom.xml 2d3dbdd 
>   hadooplibs/hadoop-utils-3/pom.xml 7270bfd 
>   hadooplibs/pom.xml e5ea2e7 
>   hbaselibs/hbase-0.94/pom.xml a65904e 
>   hbaselibs/pom.xml 24051c5 
>   hcataloglibs/hive-hcatalog-0.13.1/pom.xml b738741 
>   hcataloglibs/pom.xml a96806b 
>   minitest/pom.xml 8f656d2 
>   pom.xml 5507381 
>   sharelib/distcp/pom.xml b788ed0 
>   sharelib/hcatalog/pom.xml b934be1 
>   sharelib/hive/pom.xml ea088ff 
>   sharelib/hive2/pom.xml e4c2465 
>   sharelib/oozie/pom.xml 053cf1c 
>   sharelib/pig/pom.xml ce75c68 
>   sharelib/spark/pom.xml 744c95c 
>   sharelib/sqoop/pom.xml 09f0b66 
>   sharelib/streaming/pom.xml 50d15f7 
>   src/main/assemblies/distro.xml 8e2bbae 
>   src/main/assemblies/hadooplib.xml b32ca82 
>   src/main/assemblies/hadooplibs.xml 9884efa 
>   src/main/assemblies/hbaselib.xml 6e4db33 
>   src/main/assemblies/hbaselibs.xml eb71624 
>   src/main/assemblies/hcataloglib.xml 1002308 
>   src/main/assemblies/hcataloglibs.xml 3d32a8f 
>   tools/pom.xml 80fa425 
>   tools/src/main/bin/ooziedb.sh 68158d8 
>   webapp/pom.xml a410b10 
>   zookeeper-security-tests/pom.xml b24ce33 
> 
> Diff: https://reviews.apache.org/r/22615/diff/
> 
> 
> Testing
> -------
> 
> Clean build with different hive and hbase versions
> 
> 
> Thanks,
> 
> shwethags
> 
>


Re: Review Request 22615: OOZIE-1876 use pom properties rather than specific version numbers in the pom files of hbaselibs, hcataloglibs, sharelib, etc

Posted by sh...@inmobi.com.

> On Nov. 26, 2014, 1:58 p.m., Jaydeep Vishwakarma wrote:
> > pom.xml, line 1606
> > <https://reviews.apache.org/r/22615/diff/7/?file=776596#file776596line1606>
> >
> >     oozie.hadoop-utils.version already defined in common property.

Profile specific override. Makes it more readable


> On Nov. 26, 2014, 1:58 p.m., Jaydeep Vishwakarma wrote:
> > pom.xml, line 466
> > <https://reviews.apache.org/r/22615/diff/7/?file=776596#file776596line466>
> >
> >     why hadoop tool have distcp version.

Because hadoop-tools has distcp


> On Nov. 26, 2014, 1:58 p.m., Jaydeep Vishwakarma wrote:
> > examples/pom.xml, line 45
> > <https://reviews.apache.org/r/22615/diff/7/?file=776568#file776568line45>
> >
> >     Scope test?

The scope is already test in the base pom


> On Nov. 26, 2014, 1:58 p.m., Jaydeep Vishwakarma wrote:
> > core/pom.xml, line 46
> > <https://reviews.apache.org/r/22615/diff/7/?file=776564#file776564line46>
> >
> >     I think we use this in only for test, so scope should be test.

The scope is already test in the base pom


- shwethags


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22615/#review63106
-----------------------------------------------------------


On Nov. 26, 2014, 6:45 a.m., shwethags wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22615/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2014, 6:45 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1876
>     https://issues.apache.org/jira/browse/OOZIE-1876
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> 1. hbase/hcatalog versions configurable
> 2. Include hcatalog libs in final distro
> 
> 
> Diffs
> -----
> 
>   client/pom.xml 365276d 
>   client/src/main/bin/oozie 44943fa 
>   core/pom.xml ca40e2e 
>   distro/src/main/bin/oozied.sh 8eafc96 
>   docs/src/site/twiki/DG_QuickStart.twiki 526fbc3 
>   docs/src/site/twiki/ENG_Building.twiki 8d74b72 
>   examples/pom.xml 852d222 
>   hadooplibs/hadoop-0.23/pom.xml 6297dbd 
>   hadooplibs/hadoop-1/pom.xml f0a32a5 
>   hadooplibs/hadoop-2/pom.xml 32d4b6c 
>   hadooplibs/hadoop-3/pom.xml 4fd8f29 
>   hadooplibs/hadoop-auth-0.23/pom.xml 59cc7f1 
>   hadooplibs/hadoop-auth-1/pom.xml 7da7639 
>   hadooplibs/hadoop-auth-2/pom.xml cbdb523 
>   hadooplibs/hadoop-distcp-0.23/pom.xml 6e42986 
>   hadooplibs/hadoop-distcp-1/pom.xml 01eb123 
>   hadooplibs/hadoop-distcp-2/pom.xml 7971eb5 
>   hadooplibs/hadoop-distcp-3/pom.xml 598ee13 
>   hadooplibs/hadoop-test-0.23/pom.xml addcd11 
>   hadooplibs/hadoop-test-1/pom.xml baf5a4c 
>   hadooplibs/hadoop-test-2/pom.xml 027c813 
>   hadooplibs/hadoop-test-3/pom.xml 7176f51 
>   hadooplibs/hadoop-utils-0.23/pom.xml 91985fc 
>   hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 46c2fbd 
>   hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java 9a19770 
>   hadooplibs/hadoop-utils-1/pom.xml c81ea91 
>   hadooplibs/hadoop-utils-2/pom.xml 2d3dbdd 
>   hadooplibs/hadoop-utils-3/pom.xml 7270bfd 
>   hadooplibs/pom.xml e5ea2e7 
>   hbaselibs/hbase-0.94/pom.xml a65904e 
>   hbaselibs/pom.xml 24051c5 
>   hcataloglibs/hive-hcatalog-0.13.1/pom.xml b738741 
>   hcataloglibs/pom.xml a96806b 
>   minitest/pom.xml 8f656d2 
>   pom.xml 5507381 
>   sharelib/distcp/pom.xml b788ed0 
>   sharelib/hcatalog/pom.xml b934be1 
>   sharelib/hive/pom.xml ea088ff 
>   sharelib/hive2/pom.xml e4c2465 
>   sharelib/oozie/pom.xml 053cf1c 
>   sharelib/pig/pom.xml ce75c68 
>   sharelib/spark/pom.xml 744c95c 
>   sharelib/sqoop/pom.xml 09f0b66 
>   sharelib/streaming/pom.xml 50d15f7 
>   src/main/assemblies/distro.xml 8e2bbae 
>   src/main/assemblies/hadooplib.xml b32ca82 
>   src/main/assemblies/hadooplibs.xml 9884efa 
>   src/main/assemblies/hbaselib.xml 6e4db33 
>   src/main/assemblies/hbaselibs.xml eb71624 
>   src/main/assemblies/hcataloglib.xml 1002308 
>   src/main/assemblies/hcataloglibs.xml 3d32a8f 
>   tools/pom.xml 80fa425 
>   tools/src/main/bin/ooziedb.sh 68158d8 
>   webapp/pom.xml a410b10 
>   zookeeper-security-tests/pom.xml b24ce33 
> 
> Diff: https://reviews.apache.org/r/22615/diff/
> 
> 
> Testing
> -------
> 
> Clean build with different hive and hbase versions
> 
> 
> Thanks,
> 
> shwethags
> 
>


Re: Review Request 22615: OOZIE-1876 use pom properties rather than specific version numbers in the pom files of hbaselibs, hcataloglibs, sharelib, etc

Posted by Jaydeep Vishwakarma <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22615/#review63106
-----------------------------------------------------------



client/pom.xml
<https://reviews.apache.org/r/22615/#comment105284>

    This change can be revert as the only position change.



core/pom.xml
<https://reviews.apache.org/r/22615/#comment105280>

    I think we use this in only for test, so scope should be test.



examples/pom.xml
<https://reviews.apache.org/r/22615/#comment105281>

    Scope test?



pom.xml
<https://reviews.apache.org/r/22615/#comment105282>

    why hadoop tool have distcp version.



pom.xml
<https://reviews.apache.org/r/22615/#comment105283>

    oozie.hadoop-utils.version already defined in common property.


- Jaydeep Vishwakarma


On Nov. 26, 2014, 6:45 a.m., shwethags wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22615/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2014, 6:45 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1876
>     https://issues.apache.org/jira/browse/OOZIE-1876
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> 1. hbase/hcatalog versions configurable
> 2. Include hcatalog libs in final distro
> 
> 
> Diffs
> -----
> 
>   client/pom.xml 365276d 
>   client/src/main/bin/oozie 44943fa 
>   core/pom.xml ca40e2e 
>   distro/src/main/bin/oozied.sh 8eafc96 
>   docs/src/site/twiki/DG_QuickStart.twiki 526fbc3 
>   docs/src/site/twiki/ENG_Building.twiki 8d74b72 
>   examples/pom.xml 852d222 
>   hadooplibs/hadoop-0.23/pom.xml 6297dbd 
>   hadooplibs/hadoop-1/pom.xml f0a32a5 
>   hadooplibs/hadoop-2/pom.xml 32d4b6c 
>   hadooplibs/hadoop-3/pom.xml 4fd8f29 
>   hadooplibs/hadoop-auth-0.23/pom.xml 59cc7f1 
>   hadooplibs/hadoop-auth-1/pom.xml 7da7639 
>   hadooplibs/hadoop-auth-2/pom.xml cbdb523 
>   hadooplibs/hadoop-distcp-0.23/pom.xml 6e42986 
>   hadooplibs/hadoop-distcp-1/pom.xml 01eb123 
>   hadooplibs/hadoop-distcp-2/pom.xml 7971eb5 
>   hadooplibs/hadoop-distcp-3/pom.xml 598ee13 
>   hadooplibs/hadoop-test-0.23/pom.xml addcd11 
>   hadooplibs/hadoop-test-1/pom.xml baf5a4c 
>   hadooplibs/hadoop-test-2/pom.xml 027c813 
>   hadooplibs/hadoop-test-3/pom.xml 7176f51 
>   hadooplibs/hadoop-utils-0.23/pom.xml 91985fc 
>   hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 46c2fbd 
>   hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java 9a19770 
>   hadooplibs/hadoop-utils-1/pom.xml c81ea91 
>   hadooplibs/hadoop-utils-2/pom.xml 2d3dbdd 
>   hadooplibs/hadoop-utils-3/pom.xml 7270bfd 
>   hadooplibs/pom.xml e5ea2e7 
>   hbaselibs/hbase-0.94/pom.xml a65904e 
>   hbaselibs/pom.xml 24051c5 
>   hcataloglibs/hive-hcatalog-0.13.1/pom.xml b738741 
>   hcataloglibs/pom.xml a96806b 
>   minitest/pom.xml 8f656d2 
>   pom.xml 5507381 
>   sharelib/distcp/pom.xml b788ed0 
>   sharelib/hcatalog/pom.xml b934be1 
>   sharelib/hive/pom.xml ea088ff 
>   sharelib/hive2/pom.xml e4c2465 
>   sharelib/oozie/pom.xml 053cf1c 
>   sharelib/pig/pom.xml ce75c68 
>   sharelib/spark/pom.xml 744c95c 
>   sharelib/sqoop/pom.xml 09f0b66 
>   sharelib/streaming/pom.xml 50d15f7 
>   src/main/assemblies/distro.xml 8e2bbae 
>   src/main/assemblies/hadooplib.xml b32ca82 
>   src/main/assemblies/hadooplibs.xml 9884efa 
>   src/main/assemblies/hbaselib.xml 6e4db33 
>   src/main/assemblies/hbaselibs.xml eb71624 
>   src/main/assemblies/hcataloglib.xml 1002308 
>   src/main/assemblies/hcataloglibs.xml 3d32a8f 
>   tools/pom.xml 80fa425 
>   tools/src/main/bin/ooziedb.sh 68158d8 
>   webapp/pom.xml a410b10 
>   zookeeper-security-tests/pom.xml b24ce33 
> 
> Diff: https://reviews.apache.org/r/22615/diff/
> 
> 
> Testing
> -------
> 
> Clean build with different hive and hbase versions
> 
> 
> Thanks,
> 
> shwethags
> 
>


Re: Review Request 22615: OOZIE-1876 use pom properties rather than specific version numbers in the pom files of hbaselibs, hcataloglibs, sharelib, etc

Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22615/
-----------------------------------------------------------

(Updated Nov. 26, 2014, 6:45 a.m.)


Review request for oozie.


Bugs: OOZIE-1876
    https://issues.apache.org/jira/browse/OOZIE-1876


Repository: oozie-git


Description
-------

1. hbase/hcatalog versions configurable
2. Include hcatalog libs in final distro


Diffs (updated)
-----

  client/pom.xml 365276d 
  client/src/main/bin/oozie 44943fa 
  core/pom.xml ca40e2e 
  distro/src/main/bin/oozied.sh 8eafc96 
  docs/src/site/twiki/DG_QuickStart.twiki 526fbc3 
  docs/src/site/twiki/ENG_Building.twiki 8d74b72 
  examples/pom.xml 852d222 
  hadooplibs/hadoop-0.23/pom.xml 6297dbd 
  hadooplibs/hadoop-1/pom.xml f0a32a5 
  hadooplibs/hadoop-2/pom.xml 32d4b6c 
  hadooplibs/hadoop-3/pom.xml 4fd8f29 
  hadooplibs/hadoop-auth-0.23/pom.xml 59cc7f1 
  hadooplibs/hadoop-auth-1/pom.xml 7da7639 
  hadooplibs/hadoop-auth-2/pom.xml cbdb523 
  hadooplibs/hadoop-distcp-0.23/pom.xml 6e42986 
  hadooplibs/hadoop-distcp-1/pom.xml 01eb123 
  hadooplibs/hadoop-distcp-2/pom.xml 7971eb5 
  hadooplibs/hadoop-distcp-3/pom.xml 598ee13 
  hadooplibs/hadoop-test-0.23/pom.xml addcd11 
  hadooplibs/hadoop-test-1/pom.xml baf5a4c 
  hadooplibs/hadoop-test-2/pom.xml 027c813 
  hadooplibs/hadoop-test-3/pom.xml 7176f51 
  hadooplibs/hadoop-utils-0.23/pom.xml 91985fc 
  hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 46c2fbd 
  hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java 9a19770 
  hadooplibs/hadoop-utils-1/pom.xml c81ea91 
  hadooplibs/hadoop-utils-2/pom.xml 2d3dbdd 
  hadooplibs/hadoop-utils-3/pom.xml 7270bfd 
  hadooplibs/pom.xml e5ea2e7 
  hbaselibs/hbase-0.94/pom.xml a65904e 
  hbaselibs/pom.xml 24051c5 
  hcataloglibs/hive-hcatalog-0.13.1/pom.xml b738741 
  hcataloglibs/pom.xml a96806b 
  minitest/pom.xml 8f656d2 
  pom.xml 5507381 
  sharelib/distcp/pom.xml b788ed0 
  sharelib/hcatalog/pom.xml b934be1 
  sharelib/hive/pom.xml ea088ff 
  sharelib/hive2/pom.xml e4c2465 
  sharelib/oozie/pom.xml 053cf1c 
  sharelib/pig/pom.xml ce75c68 
  sharelib/spark/pom.xml 744c95c 
  sharelib/sqoop/pom.xml 09f0b66 
  sharelib/streaming/pom.xml 50d15f7 
  src/main/assemblies/distro.xml 8e2bbae 
  src/main/assemblies/hadooplib.xml b32ca82 
  src/main/assemblies/hadooplibs.xml 9884efa 
  src/main/assemblies/hbaselib.xml 6e4db33 
  src/main/assemblies/hbaselibs.xml eb71624 
  src/main/assemblies/hcataloglib.xml 1002308 
  src/main/assemblies/hcataloglibs.xml 3d32a8f 
  tools/pom.xml 80fa425 
  tools/src/main/bin/ooziedb.sh 68158d8 
  webapp/pom.xml a410b10 
  zookeeper-security-tests/pom.xml b24ce33 

Diff: https://reviews.apache.org/r/22615/diff/


Testing
-------

Clean build with different hive and hbase versions


Thanks,

shwethags


Re: Review Request 22615: OOZIE-1876 use pom properties rather than specific version numbers in the pom files of hbaselibs, hcataloglibs, sharelib, etc

Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22615/
-----------------------------------------------------------

(Updated Nov. 26, 2014, 6:43 a.m.)


Review request for oozie.


Bugs: OOZIE-1876
    https://issues.apache.org/jira/browse/OOZIE-1876


Repository: oozie-git


Description
-------

1. hbase/hcatalog versions configurable
2. Include hcatalog libs in final distro


Diffs (updated)
-----

  client/pom.xml 365276d 
  client/src/main/bin/oozie 44943fa 
  core/pom.xml ca40e2e 
  core/src/main/java/org/apache/oozie/service/ShareLibService.java bb0c7ed 
  distro/src/main/bin/oozied.sh 8eafc96 
  docs/src/site/twiki/DG_QuickStart.twiki 526fbc3 
  docs/src/site/twiki/ENG_Building.twiki 8d74b72 
  examples/pom.xml 852d222 
  hadooplibs/hadoop-0.23/pom.xml 6297dbd 
  hadooplibs/hadoop-1/pom.xml f0a32a5 
  hadooplibs/hadoop-2/pom.xml 32d4b6c 
  hadooplibs/hadoop-3/pom.xml 4fd8f29 
  hadooplibs/hadoop-auth-0.23/pom.xml 59cc7f1 
  hadooplibs/hadoop-auth-1/pom.xml 7da7639 
  hadooplibs/hadoop-auth-2/pom.xml cbdb523 
  hadooplibs/hadoop-distcp-0.23/pom.xml 6e42986 
  hadooplibs/hadoop-distcp-1/pom.xml 01eb123 
  hadooplibs/hadoop-distcp-2/pom.xml 7971eb5 
  hadooplibs/hadoop-distcp-3/pom.xml 598ee13 
  hadooplibs/hadoop-test-0.23/pom.xml addcd11 
  hadooplibs/hadoop-test-1/pom.xml baf5a4c 
  hadooplibs/hadoop-test-2/pom.xml 027c813 
  hadooplibs/hadoop-test-3/pom.xml 7176f51 
  hadooplibs/hadoop-utils-0.23/pom.xml 91985fc 
  hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 46c2fbd 
  hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java 9a19770 
  hadooplibs/hadoop-utils-1/pom.xml c81ea91 
  hadooplibs/hadoop-utils-2/pom.xml 2d3dbdd 
  hadooplibs/hadoop-utils-3/pom.xml 7270bfd 
  hadooplibs/pom.xml e5ea2e7 
  hbaselibs/hbase-0.94/pom.xml a65904e 
  hbaselibs/pom.xml 24051c5 
  hcataloglibs/hive-hcatalog-0.13.1/pom.xml b738741 
  hcataloglibs/pom.xml a96806b 
  minitest/pom.xml 8f656d2 
  pom.xml 5507381 
  sharelib/distcp/pom.xml b788ed0 
  sharelib/hcatalog/pom.xml b934be1 
  sharelib/hive/pom.xml ea088ff 
  sharelib/hive2/pom.xml e4c2465 
  sharelib/oozie/pom.xml 053cf1c 
  sharelib/pig/pom.xml ce75c68 
  sharelib/spark/pom.xml 744c95c 
  sharelib/sqoop/pom.xml 09f0b66 
  sharelib/streaming/pom.xml 50d15f7 
  src/main/assemblies/distro.xml 8e2bbae 
  src/main/assemblies/hadooplib.xml b32ca82 
  src/main/assemblies/hadooplibs.xml 9884efa 
  src/main/assemblies/hbaselib.xml 6e4db33 
  src/main/assemblies/hbaselibs.xml eb71624 
  src/main/assemblies/hcataloglib.xml 1002308 
  src/main/assemblies/hcataloglibs.xml 3d32a8f 
  tools/pom.xml 80fa425 
  tools/src/main/bin/ooziedb.sh 68158d8 
  webapp/pom.xml a410b10 
  zookeeper-security-tests/pom.xml b24ce33 

Diff: https://reviews.apache.org/r/22615/diff/


Testing
-------

Clean build with different hive and hbase versions


Thanks,

shwethags


Re: Review Request 22615: OOZIE-1876 use pom properties rather than specific version numbers in the pom files of hbaselibs, hcataloglibs, sharelib, etc

Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22615/
-----------------------------------------------------------

(Updated Nov. 26, 2014, 6:42 a.m.)


Review request for oozie.


Changes
-------

Re-based after spark changed


Bugs: OOZIE-1876
    https://issues.apache.org/jira/browse/OOZIE-1876


Repository: oozie-git


Description
-------

1. hbase/hcatalog versions configurable
2. Include hcatalog libs in final distro


Diffs (updated)
-----

  client/pom.xml 365276d 
  client/src/main/bin/oozie 44943fa 
  core/pom.xml ca40e2e 
  core/src/main/java/org/apache/oozie/service/ShareLibService.java bb0c7ed 
  distro/src/main/bin/oozied.sh 8eafc96 
  docs/src/site/twiki/DG_QuickStart.twiki 526fbc3 
  docs/src/site/twiki/ENG_Building.twiki 8d74b72 
  examples/pom.xml 852d222 
  hadooplibs/hadoop-0.23/pom.xml 6297dbd 
  hadooplibs/hadoop-1/pom.xml f0a32a5 
  hadooplibs/hadoop-2/pom.xml 32d4b6c 
  hadooplibs/hadoop-3/pom.xml 4fd8f29 
  hadooplibs/hadoop-auth-0.23/pom.xml 59cc7f1 
  hadooplibs/hadoop-auth-1/pom.xml 7da7639 
  hadooplibs/hadoop-auth-2/pom.xml cbdb523 
  hadooplibs/hadoop-distcp-0.23/pom.xml 6e42986 
  hadooplibs/hadoop-distcp-1/pom.xml 01eb123 
  hadooplibs/hadoop-distcp-2/pom.xml 7971eb5 
  hadooplibs/hadoop-distcp-3/pom.xml 598ee13 
  hadooplibs/hadoop-test-0.23/pom.xml addcd11 
  hadooplibs/hadoop-test-1/pom.xml baf5a4c 
  hadooplibs/hadoop-test-2/pom.xml 027c813 
  hadooplibs/hadoop-test-3/pom.xml 7176f51 
  hadooplibs/hadoop-utils-0.23/pom.xml 91985fc 
  hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 46c2fbd 
  hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java 9a19770 
  hadooplibs/hadoop-utils-1/pom.xml c81ea91 
  hadooplibs/hadoop-utils-2/pom.xml 2d3dbdd 
  hadooplibs/hadoop-utils-3/pom.xml 7270bfd 
  hadooplibs/pom.xml e5ea2e7 
  hbaselibs/hbase-0.94/pom.xml a65904e 
  hbaselibs/pom.xml 24051c5 
  hcataloglibs/hive-hcatalog-0.13.1/pom.xml b738741 
  hcataloglibs/pom.xml a96806b 
  minitest/pom.xml 8f656d2 
  pom.xml 5507381 
  sharelib/distcp/pom.xml b788ed0 
  sharelib/hcatalog/pom.xml b934be1 
  sharelib/hive/pom.xml ea088ff 
  sharelib/hive2/pom.xml e4c2465 
  sharelib/oozie/pom.xml 053cf1c 
  sharelib/pig/pom.xml ce75c68 
  sharelib/spark/pom.xml 744c95c 
  sharelib/sqoop/pom.xml 09f0b66 
  sharelib/streaming/pom.xml 50d15f7 
  src/main/assemblies/distro.xml 8e2bbae 
  src/main/assemblies/hadooplib.xml b32ca82 
  src/main/assemblies/hadooplibs.xml 9884efa 
  src/main/assemblies/hbaselib.xml 6e4db33 
  src/main/assemblies/hbaselibs.xml eb71624 
  src/main/assemblies/hcataloglib.xml 1002308 
  src/main/assemblies/hcataloglibs.xml 3d32a8f 
  tools/pom.xml 80fa425 
  tools/src/main/bin/ooziedb.sh 68158d8 
  webapp/pom.xml a410b10 
  zookeeper-security-tests/pom.xml b24ce33 

Diff: https://reviews.apache.org/r/22615/diff/


Testing
-------

Clean build with different hive and hbase versions


Thanks,

shwethags


Re: Review Request 22615: OOZIE-1876 use pom properties rather than specific version numbers in the pom files of hbaselibs, hcataloglibs, sharelib, etc

Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22615/
-----------------------------------------------------------

(Updated Nov. 20, 2014, 11:59 a.m.)


Review request for oozie.


Changes
-------

Finally, here is a working patch

Here are the changes:
1. All the versions are configurable - hadoop, hive, distcp, auth
2. oozie.war bundles all the required jars - required hadoop and hcat dependencies. (Reasoning: Currently, we need to add hadoop and hcat jars at runtime in libext. Since we won't know which are the exact jars required, we end up adding everything in hadoop and hcat classpath. In newer versions of hadoop and hive, there are so many jars that the final oozie application has multiple versions of the same jar and creates conflicts)
3. ooze-start without ooze-setup does setup automatically
4. Removed packaging jars in lib and libtools. Instead, picks up the jars by exploding oozie.war

Testing:
1. Compiled using different combinations of hadoop profile and version
2. Verified few workflows with oozie setup with hadoop-2.5.0


Bugs: OOZIE-1876
    https://issues.apache.org/jira/browse/OOZIE-1876


Repository: oozie-git


Description
-------

1. hbase/hcatalog versions configurable
2. Include hcatalog libs in final distro


Diffs (updated)
-----

  client/pom.xml 365276d 
  client/src/main/bin/oozie 44943fa 
  core/pom.xml ca40e2e 
  distro/src/main/bin/oozied.sh 8eafc96 
  docs/src/site/twiki/DG_QuickStart.twiki 526fbc3 
  docs/src/site/twiki/ENG_Building.twiki 8d74b72 
  examples/pom.xml 852d222 
  hadooplibs/hadoop-0.23/pom.xml 6297dbd 
  hadooplibs/hadoop-1/pom.xml f0a32a5 
  hadooplibs/hadoop-2/pom.xml 32d4b6c 
  hadooplibs/hadoop-3/pom.xml 4fd8f29 
  hadooplibs/hadoop-auth-0.23/pom.xml 59cc7f1 
  hadooplibs/hadoop-auth-1/pom.xml 7da7639 
  hadooplibs/hadoop-auth-2/pom.xml cbdb523 
  hadooplibs/hadoop-distcp-0.23/pom.xml 6e42986 
  hadooplibs/hadoop-distcp-1/pom.xml 01eb123 
  hadooplibs/hadoop-distcp-2/pom.xml 7971eb5 
  hadooplibs/hadoop-distcp-3/pom.xml 598ee13 
  hadooplibs/hadoop-test-0.23/pom.xml addcd11 
  hadooplibs/hadoop-test-1/pom.xml baf5a4c 
  hadooplibs/hadoop-test-2/pom.xml 027c813 
  hadooplibs/hadoop-test-3/pom.xml 7176f51 
  hadooplibs/hadoop-utils-0.23/pom.xml 91985fc 
  hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 46c2fbd 
  hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java 9a19770 
  hadooplibs/hadoop-utils-1/pom.xml c81ea91 
  hadooplibs/hadoop-utils-2/pom.xml 2d3dbdd 
  hadooplibs/hadoop-utils-3/pom.xml 7270bfd 
  hadooplibs/pom.xml e5ea2e7 
  hbaselibs/hbase-0.94/pom.xml a65904e 
  hbaselibs/pom.xml 24051c5 
  hcataloglibs/hive-hcatalog-0.13.1/pom.xml b738741 
  hcataloglibs/pom.xml a96806b 
  minitest/pom.xml 8f656d2 
  pom.xml 1e79186 
  sharelib/distcp/pom.xml b788ed0 
  sharelib/hcatalog/pom.xml b934be1 
  sharelib/hive/pom.xml ea088ff 
  sharelib/hive2/pom.xml e4c2465 
  sharelib/oozie/pom.xml 053cf1c 
  sharelib/pig/pom.xml ce75c68 
  sharelib/sqoop/pom.xml 09f0b66 
  sharelib/streaming/pom.xml 50d15f7 
  src/main/assemblies/distro.xml 8e2bbae 
  src/main/assemblies/hadooplib.xml b32ca82 
  src/main/assemblies/hadooplibs.xml 9884efa 
  src/main/assemblies/hbaselib.xml 6e4db33 
  src/main/assemblies/hbaselibs.xml eb71624 
  src/main/assemblies/hcataloglib.xml 1002308 
  src/main/assemblies/hcataloglibs.xml 3d32a8f 
  tools/pom.xml 80fa425 
  tools/src/main/bin/ooziedb.sh 68158d8 
  webapp/pom.xml 35776c5 
  zookeeper-security-tests/pom.xml b24ce33 

Diff: https://reviews.apache.org/r/22615/diff/


Testing
-------

Clean build with different hive and hbase versions


Thanks,

shwethags


Re: Review Request 22615: OOZIE-1876 use pom properties rather than specific version numbers in the pom files of hbaselibs, hcataloglibs, sharelib, etc

Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22615/
-----------------------------------------------------------

(Updated Aug. 19, 2014, 5:34 a.m.)


Review request for oozie.


Bugs: OOZIE-1876
    https://issues.apache.org/jira/browse/OOZIE-1876


Repository: oozie-git


Description (updated)
-------

1. hbase/hcatalog versions configurable
2. Include hcatalog libs in final distro


Diffs (updated)
-----

  core/pom.xml 5b2eedc 
  hbaselibs/hbase-0.94/pom.xml a65904e 
  hbaselibs/pom.xml 24051c5 
  hcataloglibs/hive-hcatalog-0.13.1/pom.xml b738741 
  hcataloglibs/pom.xml a96806b 
  pom.xml c5bca2b 
  sharelib/distcp/pom.xml 04e436d 
  sharelib/hcatalog/pom.xml b934be1 
  sharelib/hive/pom.xml ea088ff 
  sharelib/pig/pom.xml ce75c68 
  sharelib/sqoop/pom.xml 09f0b66 
  sharelib/streaming/pom.xml 50d15f7 
  src/main/assemblies/distro.xml 8e2bbae 
  src/main/assemblies/hbaselib.xml 6e4db33 
  src/main/assemblies/hbaselibs.xml eb71624 
  src/main/assemblies/hcataloglib.xml 1002308 
  src/main/assemblies/hcataloglibs.xml 3d32a8f 
  tools/pom.xml a8c69cc 

Diff: https://reviews.apache.org/r/22615/diff/


Testing (updated)
-------

Clean build with different hive and hbase versions


Thanks,

shwethags


Re: Review Request 22615: OOZIE-1876 use pom properties rather than specific version numbers in the pom files of hbaselibs, hcataloglibs, sharelib, etc

Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22615/
-----------------------------------------------------------

(Updated June 17, 2014, 7:12 a.m.)


Review request for oozie.


Bugs: OOZIE-1876
    https://issues.apache.org/jira/browse/OOZIE-1876


Repository: oozie-git


Description (updated)
-------

1. hadoop/hbase/hcatalog versions configurable
2. Include hadooplibs in final distro
3. Renamed oozie-default.xml in final distro

Usage:
mvn clean package [-Dhadoop.version=<version>] - hadoop-1 build
mvn clean package -P hadoop-2 [-Dhadoop.version=<version>] - hadoop-2 build
mvn clean package -P hadoop-3 [-Dhadoop.version=<version>] - hadoop-3 build
mvn clean package -P hadoop-23 [-Dhadoop.version=<version>] - hadoop-0.23 build


Diffs
-----

  core/pom.xml c935dd7 
  distro/pom.xml 25370c0 
  examples/pom.xml b70ffec 
  hadooplibs/hadoop-0.23/pom.xml f01975e 
  hadooplibs/hadoop-1/pom.xml 30a5996 
  hadooplibs/hadoop-2/pom.xml a02422a 
  hadooplibs/hadoop-3/pom.xml b63bbe4 
  hadooplibs/hadoop-distcp-0.23/pom.xml 36414ba 
  hadooplibs/hadoop-distcp-1/pom.xml fa21703 
  hadooplibs/hadoop-distcp-2/pom.xml d5d37d6 
  hadooplibs/hadoop-distcp-3/pom.xml 491407e 
  hadooplibs/hadoop-distcp/pom.xml PRE-CREATION 
  hadooplibs/hadoop-libs/pom.xml PRE-CREATION 
  hadooplibs/hadoop-test-0.23/pom.xml b0bef89 
  hadooplibs/hadoop-test-1/pom.xml 3d4b409 
  hadooplibs/hadoop-test-2/pom.xml 944dba4 
  hadooplibs/hadoop-test-3/pom.xml e1a3a93 
  hadooplibs/hadoop-utils-0.23/pom.xml 13e736f 
  hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 07a3c29 
  hadooplibs/hadoop-utils-1/pom.xml 0d10e7a 
  hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 07a3c29 
  hadooplibs/hadoop-utils-2/pom.xml ce6d531 
  hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 07a3c29 
  hadooplibs/hadoop-utils-3/pom.xml 07afb2d 
  hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java db827e5 
  hadooplibs/hadoop-utils/pom.xml PRE-CREATION 
  hadooplibs/hadoop-utils/src/versioned-src/hadoop-1/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java PRE-CREATION 
  hadooplibs/hadoop-utils/src/versioned-src/hadoop-2/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java PRE-CREATION 
  hadooplibs/hadoop-utils/src/versioned-src/hadoop-23/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java PRE-CREATION 
  hadooplibs/hadoop-utils/src/versioned-src/hadoop-3/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java PRE-CREATION 
  hadooplibs/pom.xml 788788c 
  hbaselibs/hbase-0.94/pom.xml 6b2526c 
  hbaselibs/pom.xml 8369121 
  hcataloglibs/hcatalog-0.5/pom.xml 457874d 
  hcataloglibs/hcatalog-0.6/pom.xml 98ae13e 
  hcataloglibs/pom.xml cde7bb9 
  minitest/pom.xml 0a6030f 
  pom.xml b5e0e4e 
  sharelib/distcp/pom.xml 486162a 
  sharelib/hcatalog/pom.xml 4efa5e0 
  sharelib/hive/pom.xml 5ca5cb8 
  sharelib/oozie/pom.xml 22a01b6 
  sharelib/pig/pom.xml 6f99523 
  sharelib/sqoop/pom.xml 8925376 
  sharelib/streaming/pom.xml aceab41 
  src/main/assemblies/distro.xml 8e2bbae 
  src/main/assemblies/hadooplib.xml b32ca82 
  src/main/assemblies/hadooplibs.xml 9884efa 
  src/main/assemblies/hbaselib.xml 6e4db33 
  src/main/assemblies/hbaselibs.xml eb71624 
  src/main/assemblies/hcataloglib.xml 1002308 
  src/main/assemblies/hcataloglibs.xml d00d34b 
  tools/pom.xml 487783d 
  webapp/pom.xml 93cfcef 

Diff: https://reviews.apache.org/r/22615/diff/


Testing
-------

Clean build with different hadoop profiles, verified distro that it contains the same files as before


Thanks,

shwethags


Re: Review Request 22615: OOZIE-1876 use pom properties rather than specific version numbers in the pom files of hbaselibs, hcataloglibs, sharelib, etc

Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22615/
-----------------------------------------------------------

(Updated June 17, 2014, 7:11 a.m.)


Review request for oozie.


Changes
-------

Added new property for hadoop-auth version


Bugs: OOZIE-1876
    https://issues.apache.org/jira/browse/OOZIE-1876


Repository: oozie-git


Description
-------

1. hadoop/hbase/hcatalog versions configurable
2. Include hadooplibs in final distro
3. Renamed oozie-default.xml in final distro


Diffs (updated)
-----

  core/pom.xml c935dd7 
  distro/pom.xml 25370c0 
  examples/pom.xml b70ffec 
  hadooplibs/hadoop-0.23/pom.xml f01975e 
  hadooplibs/hadoop-1/pom.xml 30a5996 
  hadooplibs/hadoop-2/pom.xml a02422a 
  hadooplibs/hadoop-3/pom.xml b63bbe4 
  hadooplibs/hadoop-distcp-0.23/pom.xml 36414ba 
  hadooplibs/hadoop-distcp-1/pom.xml fa21703 
  hadooplibs/hadoop-distcp-2/pom.xml d5d37d6 
  hadooplibs/hadoop-distcp-3/pom.xml 491407e 
  hadooplibs/hadoop-distcp/pom.xml PRE-CREATION 
  hadooplibs/hadoop-libs/pom.xml PRE-CREATION 
  hadooplibs/hadoop-test-0.23/pom.xml b0bef89 
  hadooplibs/hadoop-test-1/pom.xml 3d4b409 
  hadooplibs/hadoop-test-2/pom.xml 944dba4 
  hadooplibs/hadoop-test-3/pom.xml e1a3a93 
  hadooplibs/hadoop-utils-0.23/pom.xml 13e736f 
  hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 07a3c29 
  hadooplibs/hadoop-utils-1/pom.xml 0d10e7a 
  hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 07a3c29 
  hadooplibs/hadoop-utils-2/pom.xml ce6d531 
  hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 07a3c29 
  hadooplibs/hadoop-utils-3/pom.xml 07afb2d 
  hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java db827e5 
  hadooplibs/hadoop-utils/pom.xml PRE-CREATION 
  hadooplibs/hadoop-utils/src/versioned-src/hadoop-1/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java PRE-CREATION 
  hadooplibs/hadoop-utils/src/versioned-src/hadoop-2/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java PRE-CREATION 
  hadooplibs/hadoop-utils/src/versioned-src/hadoop-23/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java PRE-CREATION 
  hadooplibs/hadoop-utils/src/versioned-src/hadoop-3/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java PRE-CREATION 
  hadooplibs/pom.xml 788788c 
  hbaselibs/hbase-0.94/pom.xml 6b2526c 
  hbaselibs/pom.xml 8369121 
  hcataloglibs/hcatalog-0.5/pom.xml 457874d 
  hcataloglibs/hcatalog-0.6/pom.xml 98ae13e 
  hcataloglibs/pom.xml cde7bb9 
  minitest/pom.xml 0a6030f 
  pom.xml b5e0e4e 
  sharelib/distcp/pom.xml 486162a 
  sharelib/hcatalog/pom.xml 4efa5e0 
  sharelib/hive/pom.xml 5ca5cb8 
  sharelib/oozie/pom.xml 22a01b6 
  sharelib/pig/pom.xml 6f99523 
  sharelib/sqoop/pom.xml 8925376 
  sharelib/streaming/pom.xml aceab41 
  src/main/assemblies/distro.xml 8e2bbae 
  src/main/assemblies/hadooplib.xml b32ca82 
  src/main/assemblies/hadooplibs.xml 9884efa 
  src/main/assemblies/hbaselib.xml 6e4db33 
  src/main/assemblies/hbaselibs.xml eb71624 
  src/main/assemblies/hcataloglib.xml 1002308 
  src/main/assemblies/hcataloglibs.xml d00d34b 
  tools/pom.xml 487783d 
  webapp/pom.xml 93cfcef 

Diff: https://reviews.apache.org/r/22615/diff/


Testing
-------

Clean build with different hadoop profiles, verified distro that it contains the same files as before


Thanks,

shwethags