You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by XuMingmin <gi...@git.apache.org> on 2017/04/10 18:24:46 UTC

[GitHub] beam pull request #2482: [BEAM-1922] DataSource in JdbcIO is not closed

GitHub user XuMingmin opened a pull request:

    https://github.com/apache/beam/pull/2482

    [BEAM-1922] DataSource in JdbcIO is not closed

    add `close()` for `BasicDataSource`. When user call with `DataSourceConfiguration.create(dataSource)`, it's not available as no `close()` method is there.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/XuMingmin/beam BEAM1922

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2482.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2482
    
----
commit b0bce28b90743336233be89b645c4f8028b36538
Author: mingmxu <mi...@ebay.com>
Date:   2017-04-10T18:19:02Z

    add close() for BasicDataSource

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #2482: [BEAM-1922] DataSource in JdbcIO is not closed

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/2482


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---