[PR] fix(desktop): accept Intel Mach-O architecture in package verification [maka]

["Astro-Han (via GitHub)" <gi...@apache.org>]

Astro-Han opened a new pull request, #4589:
URL: https://github.com/apache/maka/pull/4589

   ## Summary
   
   Intel macOS Nightly packaging and Apple notarization succeed, but verification fails with `Maka executable must contain only x64, found: x86_64` ([failed run](https://github.com/apache/maka/actions/runs/33671124683/job/100384778598)). The verifier compares Node's target name directly with `lipo`'s Mach-O architecture name, preventing the entire Desktop release from publishing.
   
   Map `x64` to `x86_64` at the existing architecture assertion. Both Nightly and formal releases use this verifier; wrong architectures and universal binaries remain rejected. No artifact naming, update configuration, or migration changes are needed. The existing assertion is extended without adding a second architecture authority; the added tests cover its previously untested behavior.
   
   ## Verification
   
   - The Intel regression failed with the exact Nightly error before the fix and passed afterward.
   - `node --test scripts/verify-packaged-app.test.mjs scripts/desktop-nightly-stage.test.mjs` — 26 passed, including six macOS architecture cases and the merged release feed.
   - `npm run format` and `npm run lint` — passed.
   - Built the core, storage, MCP, and runtime workspaces required to load the verifier. No TypeScript changed.
   - The regression tests use real ASAR and update configuration fixtures, substituting macOS commands and app launches. They do not establish that a new signed Intel build or release publication succeeds.
   
   ## Rollout
   
   After review and merge, dispatch a **fresh npm Nightly**; Desktop Nightly rejects in-place workflow reruns. Confirm all five Desktop targets pass, including Intel signing verification and PTY/filesystem-worker/renderer smoke checks, then confirm the GitHub prerelease and downloadable artifacts are published. This PR has not triggered another Nightly.
   
   ## AI use
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: Codex diagnosed the failed run, implemented the mapping, and added and ran the regression tests.
   
   ## Checklist
   
   - [x] Tests cover the change and fail without it
   - [x] Lint, format, typecheck and the affected suites pass locally (typecheck is not applicable to the MJS-only changes)
   
   Does this PR entail a change in behavior?
   
   - [x] Yes — described under Summary above
   - [ ] No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org

Re: [PR] fix(desktop): accept Intel Mach-O architecture in package verification [maka]

["Astro-Han (via GitHub)" <gi...@apache.org>]

Astro-Han merged PR #4589:
URL: https://github.com/apache/maka/pull/4589


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org