You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Igor Vaynberg (JIRA)" <ji...@apache.org> on 2009/07/10 17:59:15 UTC

[jira] Updated: (WICKET-2258) Make Form.callOnError() and Form.persistFormComponentData() protected

     [ https://issues.apache.org/jira/browse/WICKET-2258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg updated WICKET-2258:
----------------------------------

    Fix Version/s:     (was: 1.4-RC7)
                   1.4-RC8

> Make Form.callOnError() and Form.persistFormComponentData() protected
> ---------------------------------------------------------------------
>
>                 Key: WICKET-2258
>                 URL: https://issues.apache.org/jira/browse/WICKET-2258
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>         Environment: Wicket 1.3.4, Wicket 1.4rc2
>            Reporter: Pablo Abad
>             Fix For: 1.4-RC8
>
>
>    We are developing a system where some complex validations are handled by the domain objects. 
>    This means that setting some properties may raise exceptions. While we are able to catch these exceptions and convert them into  meaningful error messages that get into the feedbackpanel, this only happens when updating the model, right after calling valid() on the form components, effectively discarding the values kept in the components.
> Our solution would be to alter the form processing so that:
>    + Form validators are invoked
>    + If none fails, model is updated
>    + if the update doesn't  fail, components are marked as valid
>    Since this would change the actual form processing cycle, we do not expect Wicket to provide this behavior out of the box, but when we attempted to subclass Form, and override process() we found out that methods callOnError() and persistFormComponentData() called in the implementation of that method are private. We need them to be at least protected so that we can rewrite the onProcess to suit our needs

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.