You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iota.apache.org by shiv4nsh <gi...@git.apache.org> on 2016/07/06 13:49:55 UTC
[GitHub] incubator-iota pull request #8: [IOTA-22] [IOTA-23] Rebased the new code and...
GitHub user shiv4nsh opened a pull request:
https://github.com/apache/incubator-iota/pull/8
[IOTA-22] [IOTA-23] Rebased the new code and incorporated the changes for the jar name and moving project from spray to p
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shiv4nsh/incubator-iota master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-iota/pull/8.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8
----
commit 80071c32235078d3424d967379102c18ef102d28
Author: Shivansh <sh...@knoldus.com>
Date: 2016-07-06T12:39:16Z
[IOTA-23] Added the dependency and plugin for play and removed spray dependencies
commit ed0e6ff62de0c010277c44799c728e9c6a5babf2
Author: Shivansh <sh...@knoldus.com>
Date: 2016-07-06T13:04:43Z
[IOTA-23] Refactored the class so that it should use the play-netty server instead of spray and provided the basic UI
commit ca9804700c2fa53a2e370a4463f06879dc2002cd
Author: Shivansh <sh...@knoldus.com>
Date: 2016-07-06T13:05:38Z
[IOTA-23] Added the configuration so that the port and the address should be picked from the application.conf
commit 6ab7d112d716f3c5ced30d0d2dc12f1b9efb7fd6
Author: Shivansh <sh...@knoldus.com>
Date: 2016-07-06T13:06:50Z
[IOTA-23] Refactored the code for the main application to start netty server instead of spray server
commit 93cea3fc4284e5f6d34579a76e5553ecba0e2b4f
Author: Shivansh <sh...@knoldus.com>
Date: 2016-07-06T13:40:22Z
[IOTA-22] Fixed the issue of the jar name
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-iota issue #8: [IOTA-22] [IOTA-23]
Posted by shiv4nsh <gi...@git.apache.org>.
Github user shiv4nsh commented on the issue:
https://github.com/apache/incubator-iota/pull/8
@barbaragomes : Please review this pull request and let me know your concerns. I have rebased with the new code and made the changes and also please discard the pull request https://github.com/apache/incubator-iota/pull/6 as it is not mergable. Thanks !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-iota issue #8: [IOTA-22] [IOTA-23]
Posted by barbaragomes <gi...@git.apache.org>.
Github user barbaragomes commented on the issue:
https://github.com/apache/incubator-iota/pull/8
@shiv4nsh We apologize for the late response.
I understand that we haven't give you much details about this issue, my apologies.
We haven't accepted this PR because we are working on a better specification of the first steps to integrate play as well as some UI prototypes, so we can make this issue more clear.
We appreciate your contribution.
We will be updating this issue with more details soon.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-iota issue #8: [IOTA-22] [IOTA-23]
Posted by shiv4nsh <gi...@git.apache.org>.
Github user shiv4nsh commented on the issue:
https://github.com/apache/incubator-iota/pull/8
@barbaragomes : Ok please provide the specifications of this ticket so that we can work efficiently on this ticket. Thanks !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-iota issue #8: [IOTA-22] [IOTA-23]
Posted by shiv4nsh <gi...@git.apache.org>.
Github user shiv4nsh commented on the issue:
https://github.com/apache/incubator-iota/pull/8
@barbaragomes and @tonyfaustini : I have rebased the code and done the changes again , and have made the pull Request against it i.e #19 and #20 that contains changes for this PR and hence i am Closing this ! Please review those ! Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-iota pull request #8: [IOTA-22] [IOTA-23]
Posted by shiv4nsh <gi...@git.apache.org>.
Github user shiv4nsh closed the pull request at:
https://github.com/apache/incubator-iota/pull/8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---