You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/10/30 00:13:41 UTC

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6794: [TOPI] Add embedding op and gradient

tqchen edited a comment on pull request #6794:
URL: https://github.com/apache/incubator-tvm/pull/6794#issuecomment-719094251


   Thanks @tkonolige , given that this is a new op, it would be great to do a API review per https://tvm.apache.org/docs/contribute/code_review.html#deliberate-on-api-and-data-structures
   
   In particular, it would be great to checkout the convention of similar APIs in existing frameworks like numpy, PyTorch, Keras, TensorFlow, we should ideally follow common conventions. See previous related topics on nms https://github.com/apache/incubator-tvm/issues/2535


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org