You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/20 09:21:56 UTC
[GitHub] [incubator-nuttx] eenurkka opened a new pull request #5287: Mpfs opensbi fixes
eenurkka opened a new pull request #5287:
URL: https://github.com/apache/incubator-nuttx/pull/5287
## Summary
PR #5264 fails due to OpenSBI dependency to riscv_internal.h.
There's been efforts to use OPENSBI_EXTERNAL_SBI_TYPES, but then many NuttX header files would need to be collected to form such an entry. Updating it would be pointless, as OpenSBI is rather seen as a separate entity. We'd like to have less dependency to any OpenSBI headers. The unfortunate file mpfs_opensbi.c is in the middle of both: it needs some NuttX headers but also some OpenSBI headers.
Also remove unnecessary uart1 reset on a separate patch.
## Impact
No impact, PR #5264 will pass
## Testing
Polarfire Icicle board
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5287: Mpfs opensbi redefinition fixes
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5287:
URL: https://github.com/apache/incubator-nuttx/pull/5287#discussion_r788776206
##########
File path: arch/risc-v/src/mpfs/mpfs_opensbi.c
##########
@@ -118,6 +117,16 @@ static int mpfs_irqchip_init(bool cold_boot);
static int mpfs_ipi_init(bool cold_boot);
static int mpfs_timer_init(bool cold_boot);
+/****************************************************************************
+ * Extern Function Declarations
+ ****************************************************************************/
+
+/* riscv_internal.h cannot be included due to a number of redefinition
+ * conflicts. Thus, define the riscv_lowputc() with the extern definition.
+ */
+
+extern void riscv_lowputc(char ch);
Review comment:
I created https://github.com/apache/incubator-nuttx/pull/5292 to handle this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5287: Mpfs opensbi redefinition fixes
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5287:
URL: https://github.com/apache/incubator-nuttx/pull/5287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5287: Mpfs opensbi redefinition fixes
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5287:
URL: https://github.com/apache/incubator-nuttx/pull/5287#discussion_r788769675
##########
File path: arch/risc-v/src/mpfs/mpfs_opensbi.c
##########
@@ -118,6 +117,16 @@ static int mpfs_irqchip_init(bool cold_boot);
static int mpfs_ipi_init(bool cold_boot);
static int mpfs_timer_init(bool cold_boot);
+/****************************************************************************
+ * Extern Function Declarations
+ ****************************************************************************/
+
+/* riscv_internal.h cannot be included due to a number of redefinition
+ * conflicts. Thus, define the riscv_lowputc() with the extern definition.
+ */
+
+extern void riscv_lowputc(char ch);
Review comment:
Maybe better to switch to `up_putc` and include `nuttx/arch.h`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org