You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2019/07/30 07:51:03 UTC
Review Request 71192: Propagate ephemeral volume information from
rootfs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71192/
-----------------------------------------------------------
Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu.
Bugs: MESOS-9900
https://issues.apache.org/jira/browse/MESOS-9900
Repository: mesos
Description
-------
Propagate the overlayfs upperdir path to the containerization layer
in a general form as a set of ephemeral volume paths.
Diffs
-----
include/mesos/slave/containerizer.proto a60c96302a6cec90ecd0a0885b844fff8d37db71
src/slave/containerizer/mesos/containerizer.cpp a01edc8793a2eaa655f1729a01a01f1f61fbf7cb
src/slave/containerizer/mesos/provisioner/backend.hpp 7257d3a962ecdf87fe9d52facbd6a2619311a018
src/slave/containerizer/mesos/provisioner/backends/aufs.hpp 2c2518775d2bcb3b1857775723828c4ac08111ca
src/slave/containerizer/mesos/provisioner/backends/aufs.cpp 2eba55228e7596c170dddea2a9930ba6cf73404f
src/slave/containerizer/mesos/provisioner/backends/bind.hpp c4a1d5f35710f6eab13938333ed4cb97d9ff2f6b
src/slave/containerizer/mesos/provisioner/backends/bind.cpp 4cc4c520aa6872c05f474bc7837a353b43983e0b
src/slave/containerizer/mesos/provisioner/backends/copy.hpp 5dc9a2fd38cdfafda02129b0d144eee3230a1ff2
src/slave/containerizer/mesos/provisioner/backends/copy.cpp 10516caab82d910944814b80e0a1d9aeba19007c
src/slave/containerizer/mesos/provisioner/backends/overlay.hpp 362e02172d2fd8e6e241fb6f5689f569ba74a0d1
src/slave/containerizer/mesos/provisioner/backends/overlay.cpp f2040cf36c601a13281a78ff844ebd41000a2d65
src/slave/containerizer/mesos/provisioner/provisioner.hpp 7f84aa499b21140eb29ef7f81e2608743b12eb75
src/slave/containerizer/mesos/provisioner/provisioner.cpp a081fb059f9e0788c2153d1e04eda37fe514a1f7
Diff: https://reviews.apache.org/r/71192/diff/1/
Testing
-------
sudo make check (Frdora 30)
Thanks,
James Peach
Re: Review Request 71192: Propagate ephemeral volume information from
rootfs.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71192/#review216993
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/slave/containerizer.proto
Lines 82 (patched)
<https://reviews.apache.org/r/71192/#comment304232>
Missing comment:
```
// Ephemeral path volumes subject to container disk quota.
```
- Andrei Budnik
On Июль 30, 2019, 7:51 д.п., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71192/
> -----------------------------------------------------------
>
> (Updated Июль 30, 2019, 7:51 д.п.)
>
>
> Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu.
>
>
> Bugs: MESOS-9900
> https://issues.apache.org/jira/browse/MESOS-9900
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Propagate the overlayfs upperdir path to the containerization layer
> in a general form as a set of ephemeral volume paths.
>
>
> Diffs
> -----
>
> include/mesos/slave/containerizer.proto a60c96302a6cec90ecd0a0885b844fff8d37db71
> src/slave/containerizer/mesos/containerizer.cpp a01edc8793a2eaa655f1729a01a01f1f61fbf7cb
> src/slave/containerizer/mesos/provisioner/backend.hpp 7257d3a962ecdf87fe9d52facbd6a2619311a018
> src/slave/containerizer/mesos/provisioner/backends/aufs.hpp 2c2518775d2bcb3b1857775723828c4ac08111ca
> src/slave/containerizer/mesos/provisioner/backends/aufs.cpp 2eba55228e7596c170dddea2a9930ba6cf73404f
> src/slave/containerizer/mesos/provisioner/backends/bind.hpp c4a1d5f35710f6eab13938333ed4cb97d9ff2f6b
> src/slave/containerizer/mesos/provisioner/backends/bind.cpp 4cc4c520aa6872c05f474bc7837a353b43983e0b
> src/slave/containerizer/mesos/provisioner/backends/copy.hpp 5dc9a2fd38cdfafda02129b0d144eee3230a1ff2
> src/slave/containerizer/mesos/provisioner/backends/copy.cpp 10516caab82d910944814b80e0a1d9aeba19007c
> src/slave/containerizer/mesos/provisioner/backends/overlay.hpp 362e02172d2fd8e6e241fb6f5689f569ba74a0d1
> src/slave/containerizer/mesos/provisioner/backends/overlay.cpp f2040cf36c601a13281a78ff844ebd41000a2d65
> src/slave/containerizer/mesos/provisioner/provisioner.hpp 7f84aa499b21140eb29ef7f81e2608743b12eb75
> src/slave/containerizer/mesos/provisioner/provisioner.cpp a081fb059f9e0788c2153d1e04eda37fe514a1f7
>
>
> Diff: https://reviews.apache.org/r/71192/diff/1/
>
>
> Testing
> -------
>
> sudo make check (Frdora 30)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 71192: Propagate ephemeral volume information from
rootfs.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71192/#review217060
-----------------------------------------------------------
Ship it!
Ship It!
- Jiang Yan Xu
On July 31, 2019, 6:03 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71192/
> -----------------------------------------------------------
>
> (Updated July 31, 2019, 6:03 p.m.)
>
>
> Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu.
>
>
> Bugs: MESOS-9900
> https://issues.apache.org/jira/browse/MESOS-9900
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Propagate the overlayfs upperdir path to the containerization
> layer in a general form as a set of ephemeral volume paths.
>
>
> Diffs
> -----
>
> include/mesos/slave/containerizer.proto a60c96302a6cec90ecd0a0885b844fff8d37db71
> src/slave/containerizer/mesos/containerizer.cpp a01edc8793a2eaa655f1729a01a01f1f61fbf7cb
> src/slave/containerizer/mesos/provisioner/backend.hpp 7257d3a962ecdf87fe9d52facbd6a2619311a018
> src/slave/containerizer/mesos/provisioner/backends/aufs.hpp 2c2518775d2bcb3b1857775723828c4ac08111ca
> src/slave/containerizer/mesos/provisioner/backends/aufs.cpp 2eba55228e7596c170dddea2a9930ba6cf73404f
> src/slave/containerizer/mesos/provisioner/backends/bind.hpp c4a1d5f35710f6eab13938333ed4cb97d9ff2f6b
> src/slave/containerizer/mesos/provisioner/backends/bind.cpp 4cc4c520aa6872c05f474bc7837a353b43983e0b
> src/slave/containerizer/mesos/provisioner/backends/copy.hpp 5dc9a2fd38cdfafda02129b0d144eee3230a1ff2
> src/slave/containerizer/mesos/provisioner/backends/copy.cpp 10516caab82d910944814b80e0a1d9aeba19007c
> src/slave/containerizer/mesos/provisioner/backends/overlay.hpp 362e02172d2fd8e6e241fb6f5689f569ba74a0d1
> src/slave/containerizer/mesos/provisioner/backends/overlay.cpp f2040cf36c601a13281a78ff844ebd41000a2d65
> src/slave/containerizer/mesos/provisioner/provisioner.hpp 7f84aa499b21140eb29ef7f81e2608743b12eb75
> src/slave/containerizer/mesos/provisioner/provisioner.cpp a081fb059f9e0788c2153d1e04eda37fe514a1f7
>
>
> Diff: https://reviews.apache.org/r/71192/diff/3/
>
>
> Testing
> -------
>
> sudo make check (Frdora 30)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 71192: Propagate ephemeral volume information from
rootfs.
Posted by James Peach <jp...@apache.org>.
> On Aug. 2, 2019, 9:02 p.m., Jiang Yan Xu wrote:
> > src/slave/containerizer/mesos/provisioner/backend.hpp
> > Lines 55 (patched)
> > <https://reviews.apache.org/r/71192/diff/3/?file=2158787#file2158787line55>
> >
> > The backend abstraction probably shouldn't care about quota so probably phrasing it as "additional paths the backend has created" or something?
I'd prefer to leave this since it's more explicit and the reader has less work to find out why this is here.
> On Aug. 2, 2019, 9:02 p.m., Jiang Yan Xu wrote:
> > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp
> > Lines 243 (patched)
> > <https://reviews.apache.org/r/71192/diff/3/?file=2158795#file2158795line243>
> >
> > Nit: with initializers I don't think we wrap elements with spaces.
Fixed.
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71192/#review217057
-----------------------------------------------------------
On Aug. 1, 2019, 1:03 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71192/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2019, 1:03 a.m.)
>
>
> Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu.
>
>
> Bugs: MESOS-9900
> https://issues.apache.org/jira/browse/MESOS-9900
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Propagate the overlayfs upperdir path to the containerization
> layer in a general form as a set of ephemeral volume paths.
>
>
> Diffs
> -----
>
> include/mesos/slave/containerizer.proto a60c96302a6cec90ecd0a0885b844fff8d37db71
> src/slave/containerizer/mesos/containerizer.cpp a01edc8793a2eaa655f1729a01a01f1f61fbf7cb
> src/slave/containerizer/mesos/provisioner/backend.hpp 7257d3a962ecdf87fe9d52facbd6a2619311a018
> src/slave/containerizer/mesos/provisioner/backends/aufs.hpp 2c2518775d2bcb3b1857775723828c4ac08111ca
> src/slave/containerizer/mesos/provisioner/backends/aufs.cpp 2eba55228e7596c170dddea2a9930ba6cf73404f
> src/slave/containerizer/mesos/provisioner/backends/bind.hpp c4a1d5f35710f6eab13938333ed4cb97d9ff2f6b
> src/slave/containerizer/mesos/provisioner/backends/bind.cpp 4cc4c520aa6872c05f474bc7837a353b43983e0b
> src/slave/containerizer/mesos/provisioner/backends/copy.hpp 5dc9a2fd38cdfafda02129b0d144eee3230a1ff2
> src/slave/containerizer/mesos/provisioner/backends/copy.cpp 10516caab82d910944814b80e0a1d9aeba19007c
> src/slave/containerizer/mesos/provisioner/backends/overlay.hpp 362e02172d2fd8e6e241fb6f5689f569ba74a0d1
> src/slave/containerizer/mesos/provisioner/backends/overlay.cpp f2040cf36c601a13281a78ff844ebd41000a2d65
> src/slave/containerizer/mesos/provisioner/provisioner.hpp 7f84aa499b21140eb29ef7f81e2608743b12eb75
> src/slave/containerizer/mesos/provisioner/provisioner.cpp a081fb059f9e0788c2153d1e04eda37fe514a1f7
>
>
> Diff: https://reviews.apache.org/r/71192/diff/3/
>
>
> Testing
> -------
>
> sudo make check (Frdora 30)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 71192: Propagate ephemeral volume information from
rootfs.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71192/#review217057
-----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/backend.hpp
Lines 55 (patched)
<https://reviews.apache.org/r/71192/#comment304301>
The backend abstraction probably shouldn't care about quota so probably phrasing it as "additional paths the backend has created" or something?
src/slave/containerizer/mesos/provisioner/backends/overlay.cpp
Lines 243 (patched)
<https://reviews.apache.org/r/71192/#comment304300>
Nit: with initializers I don't think we wrap elements with spaces.
- Jiang Yan Xu
On July 31, 2019, 6:03 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71192/
> -----------------------------------------------------------
>
> (Updated July 31, 2019, 6:03 p.m.)
>
>
> Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu.
>
>
> Bugs: MESOS-9900
> https://issues.apache.org/jira/browse/MESOS-9900
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Propagate the overlayfs upperdir path to the containerization
> layer in a general form as a set of ephemeral volume paths.
>
>
> Diffs
> -----
>
> include/mesos/slave/containerizer.proto a60c96302a6cec90ecd0a0885b844fff8d37db71
> src/slave/containerizer/mesos/containerizer.cpp a01edc8793a2eaa655f1729a01a01f1f61fbf7cb
> src/slave/containerizer/mesos/provisioner/backend.hpp 7257d3a962ecdf87fe9d52facbd6a2619311a018
> src/slave/containerizer/mesos/provisioner/backends/aufs.hpp 2c2518775d2bcb3b1857775723828c4ac08111ca
> src/slave/containerizer/mesos/provisioner/backends/aufs.cpp 2eba55228e7596c170dddea2a9930ba6cf73404f
> src/slave/containerizer/mesos/provisioner/backends/bind.hpp c4a1d5f35710f6eab13938333ed4cb97d9ff2f6b
> src/slave/containerizer/mesos/provisioner/backends/bind.cpp 4cc4c520aa6872c05f474bc7837a353b43983e0b
> src/slave/containerizer/mesos/provisioner/backends/copy.hpp 5dc9a2fd38cdfafda02129b0d144eee3230a1ff2
> src/slave/containerizer/mesos/provisioner/backends/copy.cpp 10516caab82d910944814b80e0a1d9aeba19007c
> src/slave/containerizer/mesos/provisioner/backends/overlay.hpp 362e02172d2fd8e6e241fb6f5689f569ba74a0d1
> src/slave/containerizer/mesos/provisioner/backends/overlay.cpp f2040cf36c601a13281a78ff844ebd41000a2d65
> src/slave/containerizer/mesos/provisioner/provisioner.hpp 7f84aa499b21140eb29ef7f81e2608743b12eb75
> src/slave/containerizer/mesos/provisioner/provisioner.cpp a081fb059f9e0788c2153d1e04eda37fe514a1f7
>
>
> Diff: https://reviews.apache.org/r/71192/diff/3/
>
>
> Testing
> -------
>
> sudo make check (Frdora 30)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 71192: Propagate ephemeral volume information from
rootfs.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71192/
-----------------------------------------------------------
(Updated Aug. 1, 2019, 1:03 a.m.)
Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu.
Bugs: MESOS-9900
https://issues.apache.org/jira/browse/MESOS-9900
Repository: mesos
Description (updated)
-------
Propagate the overlayfs upperdir path to the containerization
layer in a general form as a set of ephemeral volume paths.
Diffs (updated)
-----
include/mesos/slave/containerizer.proto a60c96302a6cec90ecd0a0885b844fff8d37db71
src/slave/containerizer/mesos/containerizer.cpp a01edc8793a2eaa655f1729a01a01f1f61fbf7cb
src/slave/containerizer/mesos/provisioner/backend.hpp 7257d3a962ecdf87fe9d52facbd6a2619311a018
src/slave/containerizer/mesos/provisioner/backends/aufs.hpp 2c2518775d2bcb3b1857775723828c4ac08111ca
src/slave/containerizer/mesos/provisioner/backends/aufs.cpp 2eba55228e7596c170dddea2a9930ba6cf73404f
src/slave/containerizer/mesos/provisioner/backends/bind.hpp c4a1d5f35710f6eab13938333ed4cb97d9ff2f6b
src/slave/containerizer/mesos/provisioner/backends/bind.cpp 4cc4c520aa6872c05f474bc7837a353b43983e0b
src/slave/containerizer/mesos/provisioner/backends/copy.hpp 5dc9a2fd38cdfafda02129b0d144eee3230a1ff2
src/slave/containerizer/mesos/provisioner/backends/copy.cpp 10516caab82d910944814b80e0a1d9aeba19007c
src/slave/containerizer/mesos/provisioner/backends/overlay.hpp 362e02172d2fd8e6e241fb6f5689f569ba74a0d1
src/slave/containerizer/mesos/provisioner/backends/overlay.cpp f2040cf36c601a13281a78ff844ebd41000a2d65
src/slave/containerizer/mesos/provisioner/provisioner.hpp 7f84aa499b21140eb29ef7f81e2608743b12eb75
src/slave/containerizer/mesos/provisioner/provisioner.cpp a081fb059f9e0788c2153d1e04eda37fe514a1f7
Diff: https://reviews.apache.org/r/71192/diff/2/
Changes: https://reviews.apache.org/r/71192/diff/1-2/
Testing
-------
sudo make check (Frdora 30)
Thanks,
James Peach