[jira] [Commented] (FLINK-5412) Enable RocksDB tests on Windows

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15801628#comment-15801628 ] 

ASF GitHub Bot commented on FLINK-5412:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/3067

    [FLINK-5412] Enable RocksDB tests on Windows OS

    This PR re-enables several RocksDB tests.
    
    Furthermore, the `RocksDBStateBackendConfigTest#testSetDbPath` was modified to ensure that hte same normalization is applied to both the expected and actual paths.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 5412_rocks_tests_enable

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3067.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3067
    
----
commit 2dbc3c836ad42bbcfcc7264d1297fe876618d01c
Author: zentol <ch...@apache.org>
Date:   2017-01-05T15:18:38Z

    [FLINK-5412] Enable RocksDB tests on Windows OS

----


> Enable RocksDB tests on Windows
> -------------------------------
>
>                 Key: FLINK-5412
>                 URL: https://issues.apache.org/jira/browse/FLINK-5412
>             Project: Flink
>          Issue Type: Improvement
>          Components: State Backends, Checkpointing, Tests
>    Affects Versions: 1.3.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.3.0
>
>
> Several RocksDB tests were previously disabled as they could not finish successfully. We recently upgraded our RocksDB version however which adds Windows support, so we should enable these tests again. I tried them already locally and they do in fact pass.
> Except one, which fails due to path normalization:
> {code}
> RocksDBStateBackendConfigTest#testSetDbPath:
> arrays first differed at element [0]; 
> Expected :C:\Users\Zento\AppData\Local\Temp\junit842723791275019440\junit527481104946100979
> Actual   :C:/Users/Zento/AppData/Local/Temp/junit842723791275019440/junit527481104946100979
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)