You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/09/15 06:50:51 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #42944: [SPARK-45179][PYTHON] Increase Numpy minimum version to 1.21
zhengruifeng opened a new pull request, #42944:
URL: https://github.com/apache/spark/pull/42944
### What changes were proposed in this pull request?
Increase Numpy minimum version to 1.21
### Why are the changes needed?
- according to the [release history](https://pypi.org/project/numpy/#history), Numpy 1.15 was released about 5 years ago, while the last maintenance release in 1.21 was released 1 year ago;
- with 1.21 as the minimum version, we can discard all version checking in PySpark;
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
search with `ag`
```
(spark_dev_310) ➜ spark git:(master) ag --py 'numpy\.__version' python
(spark_dev_310) ➜ spark git:(master)
(spark_dev_310) ➜ spark git:(master) ag --py 'np\.__version' python
python/pyspark/ml/image.py
231: if LooseVersion(np.__version__) >= LooseVersion("1.9"):
python/pyspark/pandas/typedef/typehints.py
152: if sys.version_info >= (3, 8) and LooseVersion(np.__version__) >= LooseVersion("1.21"):
python/pyspark/pandas/tests/test_typedef.py
365: if sys.version_info >= (3, 8) and LooseVersion(np.__version__) >= LooseVersion("1.21"):
python/pyspark/pandas/tests/computation/test_apply_func.py
257: if sys.version_info >= (3, 8) and LooseVersion(np.__version__) >= LooseVersion("1.21"):
```
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #42944: [SPARK-45179][PYTHON] Increase Numpy minimum version to 1.21
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #42944: [SPARK-45179][PYTHON] Increase Numpy minimum version to 1.21
URL: https://github.com/apache/spark/pull/42944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42944: [SPARK-45179][PYTHON] Increase Numpy minimum version to 1.21
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42944:
URL: https://github.com/apache/spark/pull/42944#issuecomment-1721199404
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org