You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/12 07:17:37 UTC

[GitHub] [apisix-dashboard] idbeta opened a new issue #792: bug: echo plugin can not set headers

idbeta opened a new issue #792:
URL: https://github.com/apache/apisix-dashboard/issues/792


   - Why do you submit this issue?
   - [ ] Question or discussion
   - [x] Bug
   - [ ] Requirements
   - [ ] Feature or performance improvement
   - [ ] Other
   
   The headers option will automatically refresh as `Opthion3` when setting the other option and the headers option can not be set.
   ![image](https://user-images.githubusercontent.com/7396835/98907517-e86f5880-24f9-11eb-8630-6d59d5133822.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] nic-chen closed issue #792: bug: echo plugin can not set headers

Posted by GitBox <gi...@apache.org>.
nic-chen closed issue #792:
URL: https://github.com/apache/apisix-dashboard/issues/792


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] liuxiran commented on issue #792: bug: echo plugin can not set headers

Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #792:
URL: https://github.com/apache/apisix-dashboard/issues/792#issuecomment-726223360


   There are two errors here:
   
   1. `headers` schema should be transformed just like `proxy-rewrite` and `response-rewrite` in fe plugin component
   
   1. `echo` schema still uses Draft5, that why we will see select element `Option1` in page. so It also needs to change the echo shema to Draft7.
   ```json
   {
       "additionalProperties": false,
       "required": ["before_body","body","after_body"],
       "minProperties": 1,
       "properties": {
   	"after_body": {
   		"description": "body after the modification of filter phase.",
   			"type": "string"
   		},
   		"auth_value": {
   			"description": "auth value",
   			"type": "string"
   		},
   		"before_body": {
   			"description": "body before the filter phase.",
   			"type": "string"
   		},
   		"body": {
   			"description": "body to replace upstream response.",
   			"type": "string"
   		},
   		"headers": {
   			"description": "new headers for response",
   			"minProperties":1,
   			"type": "object"
   		}
   	},
   	"type": "object"
   }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] nic-chen commented on issue #792: bug: echo plugin can not set headers

Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #792:
URL: https://github.com/apache/apisix-dashboard/issues/792#issuecomment-744214672


   fixed by code-mirror


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on issue #792: bug: echo plugin can not set headers

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #792:
URL: https://github.com/apache/apisix-dashboard/issues/792#issuecomment-744215006


   closed by https://github.com/apache/apisix-dashboard/pull/898


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org