[GitHub] [ozone] smengcl commented on a diff in pull request #4119: HDDS-7690. [Snapshot] Use SST file list output from compaction DAG as SnapshotDiff input

[GitBox <gi...@apache.org>]

smengcl commented on code in PR #4119:
URL: https://github.com/apache/ozone/pull/4119#discussion_r1066223460


##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -710,13 +710,64 @@ public synchronized void loadAllCompactionLogs() {
     }
   }
 
+  /**
+   * Helper function that prepends SST file name with SST backup directory path,
+   * and appends the extension '.sst'.
+   */
+  private String getSSTFullPathInBackupDir(String sstFilenameWithoutExtension,

Review Comment:
   Good catch. I forgot to fix the javadoc and method name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org