You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2015/01/22 15:29:30 UTC
Review Request 30168: Create Kerberos descriptors for HDP 2.0/2.1
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30168/
-----------------------------------------------------------
Review request for Ambari, Eugene Chekanskiy, Jaimin Jetly, and Yusaku Sako.
Bugs: AMBARI-9175
https://issues.apache.org/jira/browse/AMBARI-9175
Repository: ambari
Description
-------
Descriptors required for Kerberos descriptors need to be made available to 2.0 and 2.1 HDP stacks. Preferably, these descriptors should be moved in to common-services definition.
Adjustments have been made for stack differences betwen 2.0, 2.1, and 2.2 by using inheritance and overriding Kerberos descriptors when necessary - for example for Yarn and Storm
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 8da2ff9
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/kerberos.json PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/kerberos.json 46aff38
ambari-server/src/main/resources/stacks/HDP/2.2/services/FALCON/kerberos.json 3b71af4
ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/kerberos.json 5e310bc
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/kerberos.json 8b7979e
ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/kerberos.json e7b8574
ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/kerberos.json 584a932
ambari-server/src/main/resources/stacks/HDP/2.2/services/OOZIE/kerberos.json a2a3706
ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/kerberos.json 42c3df9
ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 596d607
ambari-server/src/main/resources/stacks/HDP/2.2/services/ZOOKEEPER/kerberos.json 0a64ea5
ambari-server/src/test/java/org/apache/ambari/server/stack/KerberosDescriptorTest.java 0abb2f3
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java ef1e10c
Diff: https://reviews.apache.org/r/30168/diff/
Testing
-------
#Jenkins test results
Running org.apache.ambari.server.stack.StackManagerTest
Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.062 sec
Running org.apache.ambari.server.stack.KerberosDescriptorTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.185 sec
Ambari server suite
Tests run: 2582, Failures: 0, Errors: 0, Skipped: 15
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:02 h
[INFO] Finished at: 2015-01-22T13:13:52+00:00
[INFO] Final Memory: 43M/459M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 30168: Create Kerberos descriptors for HDP 2.0/2.1
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30168/#review71000
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On Feb. 4, 2015, 12:04 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30168/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 12:04 p.m.)
>
>
> Review request for Ambari, Emil Anca, Eugene Chekanskiy, Jaimin Jetly, and Yusaku Sako.
>
>
> Bugs: AMBARI-9175
> https://issues.apache.org/jira/browse/AMBARI-9175
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Descriptors required for Kerberos descriptors need to be made available to 2.0 and 2.1 HDP stacks. Preferably, these descriptors should be moved in to common-services definition.
>
> Adjustments have been made for stack differences betwen 2.0, 2.1, and 2.2 by using inheritance and overriding Kerberos descriptors when necessary - for example for Yarn and Storm
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 8da2ff9
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/FALCON/kerberos.json 3b71af4
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/kerberos.json 5e310bc
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/kerberos.json af8f93b
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/kerberos.json e7b8574
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/kerberos.json 584a932
> ambari-server/src/main/resources/stacks/HDP/2.2/services/OOZIE/kerberos.json a2a3706
> ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/kerberos.json 42c3df9
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 42d0c1e
> ambari-server/src/main/resources/stacks/HDP/2.2/services/ZOOKEEPER/kerberos.json 0a64ea5
> ambari-server/src/test/java/org/apache/ambari/server/stack/KerberosDescriptorTest.java b784239
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java ef1e10c
>
> Diff: https://reviews.apache.org/r/30168/diff/
>
>
> Testing
> -------
>
> #Jenkins test results
>
> Running org.apache.ambari.server.stack.StackManagerTest
> Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.062 sec
>
> Running org.apache.ambari.server.stack.KerberosDescriptorTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.185 sec
>
> Ambari server suite
> Tests run: 2582, Failures: 0, Errors: 0, Skipped: 15
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:02 h
> [INFO] Finished at: 2015-01-22T13:13:52+00:00
> [INFO] Final Memory: 43M/459M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 30168: Create Kerberos descriptors for HDP 2.0/2.1
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30168/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 7:04 a.m.)
Review request for Ambari, Emil Anca, Eugene Chekanskiy, Jaimin Jetly, and Yusaku Sako.
Changes
-------
Fixed merge issues
Bugs: AMBARI-9175
https://issues.apache.org/jira/browse/AMBARI-9175
Repository: ambari
Description
-------
Descriptors required for Kerberos descriptors need to be made available to 2.0 and 2.1 HDP stacks. Preferably, these descriptors should be moved in to common-services definition.
Adjustments have been made for stack differences betwen 2.0, 2.1, and 2.2 by using inheritance and overriding Kerberos descriptors when necessary - for example for Yarn and Storm
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 8da2ff9
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/FALCON/kerberos.json 3b71af4
ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/kerberos.json 5e310bc
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/kerberos.json af8f93b
ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/kerberos.json e7b8574
ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/kerberos.json 584a932
ambari-server/src/main/resources/stacks/HDP/2.2/services/OOZIE/kerberos.json a2a3706
ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/kerberos.json 42c3df9
ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 42d0c1e
ambari-server/src/main/resources/stacks/HDP/2.2/services/ZOOKEEPER/kerberos.json 0a64ea5
ambari-server/src/test/java/org/apache/ambari/server/stack/KerberosDescriptorTest.java b784239
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java ef1e10c
Diff: https://reviews.apache.org/r/30168/diff/
Testing
-------
#Jenkins test results
Running org.apache.ambari.server.stack.StackManagerTest
Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.062 sec
Running org.apache.ambari.server.stack.KerberosDescriptorTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.185 sec
Ambari server suite
Tests run: 2582, Failures: 0, Errors: 0, Skipped: 15
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:02 h
[INFO] Finished at: 2015-01-22T13:13:52+00:00
[INFO] Final Memory: 43M/459M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 30168: Create Kerberos descriptors for HDP 2.0/2.1
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30168/#review70698
-----------------------------------------------------------
This patch does not apply on latest trunk (b178920dda64edc3b9298e6d117fcc4047283230).
ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/kerberos.json
<https://reviews.apache.org/r/30168/#comment116048>
I believe this file was meant to be deleted.
ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json
<https://reviews.apache.org/r/30168/#comment116047>
I believe this file was meant to be deleted.
The patch for this file has whitespace changes only.
- Yusaku Sako
On Jan. 28, 2015, 10:36 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30168/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2015, 10:36 a.m.)
>
>
> Review request for Ambari, Emil Anca, Eugene Chekanskiy, Jaimin Jetly, and Yusaku Sako.
>
>
> Bugs: AMBARI-9175
> https://issues.apache.org/jira/browse/AMBARI-9175
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Descriptors required for Kerberos descriptors need to be made available to 2.0 and 2.1 HDP stacks. Preferably, these descriptors should be moved in to common-services definition.
>
> Adjustments have been made for stack differences betwen 2.0, 2.1, and 2.2 by using inheritance and overriding Kerberos descriptors when necessary - for example for Yarn and Storm
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 8da2ff9
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/kerberos.json 46aff38
> ambari-server/src/main/resources/stacks/HDP/2.2/services/FALCON/kerberos.json 3b71af4
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/kerberos.json 5e310bc
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/kerberos.json 8b7979e
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/kerberos.json e7b8574
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/kerberos.json 584a932
> ambari-server/src/main/resources/stacks/HDP/2.2/services/OOZIE/kerberos.json a2a3706
> ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/kerberos.json 42c3df9
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 596d607
> ambari-server/src/main/resources/stacks/HDP/2.2/services/ZOOKEEPER/kerberos.json 0a64ea5
> ambari-server/src/test/java/org/apache/ambari/server/stack/KerberosDescriptorTest.java 0abb2f3
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java ef1e10c
>
> Diff: https://reviews.apache.org/r/30168/diff/
>
>
> Testing
> -------
>
> #Jenkins test results
>
> Running org.apache.ambari.server.stack.StackManagerTest
> Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.062 sec
>
> Running org.apache.ambari.server.stack.KerberosDescriptorTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.185 sec
>
> Ambari server suite
> Tests run: 2582, Failures: 0, Errors: 0, Skipped: 15
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:02 h
> [INFO] Finished at: 2015-01-22T13:13:52+00:00
> [INFO] Final Memory: 43M/459M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 30168: Create Kerberos descriptors for HDP 2.0/2.1
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30168/
-----------------------------------------------------------
(Updated Jan. 28, 2015, 5:36 a.m.)
Review request for Ambari, Emil Anca, Eugene Chekanskiy, Jaimin Jetly, and Yusaku Sako.
Bugs: AMBARI-9175
https://issues.apache.org/jira/browse/AMBARI-9175
Repository: ambari
Description
-------
Descriptors required for Kerberos descriptors need to be made available to 2.0 and 2.1 HDP stacks. Preferably, these descriptors should be moved in to common-services definition.
Adjustments have been made for stack differences betwen 2.0, 2.1, and 2.2 by using inheritance and overriding Kerberos descriptors when necessary - for example for Yarn and Storm
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 8da2ff9
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/kerberos.json PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/kerberos.json 46aff38
ambari-server/src/main/resources/stacks/HDP/2.2/services/FALCON/kerberos.json 3b71af4
ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/kerberos.json 5e310bc
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/kerberos.json 8b7979e
ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/kerberos.json e7b8574
ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/kerberos.json 584a932
ambari-server/src/main/resources/stacks/HDP/2.2/services/OOZIE/kerberos.json a2a3706
ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/kerberos.json 42c3df9
ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 596d607
ambari-server/src/main/resources/stacks/HDP/2.2/services/ZOOKEEPER/kerberos.json 0a64ea5
ambari-server/src/test/java/org/apache/ambari/server/stack/KerberosDescriptorTest.java 0abb2f3
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java ef1e10c
Diff: https://reviews.apache.org/r/30168/diff/
Testing
-------
#Jenkins test results
Running org.apache.ambari.server.stack.StackManagerTest
Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.062 sec
Running org.apache.ambari.server.stack.KerberosDescriptorTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.185 sec
Ambari server suite
Tests run: 2582, Failures: 0, Errors: 0, Skipped: 15
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:02 h
[INFO] Finished at: 2015-01-22T13:13:52+00:00
[INFO] Final Memory: 43M/459M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas