[jira] [Resolved] (TOMAHAWK-1628) HtmlDataTable ignores the attribute 'rowClasses'

["Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>]

     [ https://issues.apache.org/jira/browse/TOMAHAWK-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe resolved TOMAHAWK-1628.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.14-SNAPSHOT
         Assignee: Leonardo Uribe

I just changed a little the code, because String.isEmpty() is in Java 6 and upper. Thanks to Dennis Hoersch for provide this patch.
                
> HtmlDataTable ignores the attribute 'rowClasses' 
> -------------------------------------------------
>
>                 Key: TOMAHAWK-1628
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1628
>             Project: MyFaces Tomahawk
>          Issue Type: Improvement
>    Affects Versions: 1.1.11
>         Environment: MyFaces 2.1.4, Tomahawk20 1.1.11
>            Reporter: dennis hoersch
>            Assignee: Leonardo Uribe
>             Fix For: 1.1.14-SNAPSHOT
>
>
> In org.apache.myfaces.renderkit.html.ext.HtmlTableRenderer#renderRowStyle() the _super_ renderRowStyle is only called if the attribute 'rowStyleClass' is null.
> In our environment we have something like that:
> <t:dataTable
>   rowStyleClass="#{somthing that can evaluate to null}"
>   rowClasses="listRowOdd,listRowEven"
> ...
> but the EL coerces null-values of the expression to an empty string. Therefore the rowClasses are ignored because the implementation only tests for null.
> May it possible to change that to
> if (rowStyleClass == null || rowStyleClass.isEmpty()) {
>             super.renderRowStyle(facesContext, writer, uiData, styles, rowStyleIndex);
> }
> ?
> Thank you
> dennis hoersch

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira